Skip to content

Removing duplicate grpc initialized check #95

Merged
csvance merged 1 commit intomainfrom
remove-extra-check
Jan 16, 2026
Merged

Removing duplicate grpc initialized check #95
csvance merged 1 commit intomainfrom
remove-extra-check

Conversation

@csvance
Copy link
Collaborator

@csvance csvance commented Jan 16, 2026

  • Only need one check for this and the new one is better, so remove the old
  • Don't use isready function name for grpc handle running check, this is a special case

…ized

Don't use isready function name for grpc handle running check, this is a special case
@csvance csvance merged commit ba8b793 into main Jan 16, 2026
35 of 37 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.90%. Comparing base (1ee5577) to head (35e37ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   83.80%   83.90%   +0.09%     
==========================================
  Files           7        7              
  Lines         531      528       -3     
==========================================
- Hits          445      443       -2     
+ Misses         86       85       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csvance csvance deleted the remove-extra-check branch February 22, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants