Skip to content

Commit 3af1ec5

Browse files
authored
Merge pull request #180 from JuliaImGui/makie-update
Fix GLMakie 0.13 compatibility and bump version
2 parents 8a6c13c + c9648ad commit 3af1ec5

20 files changed

+1839
-80
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
version:
22-
- '1.9'
22+
- '1.10'
2323
- '1'
2424
- 'nightly'
2525
os:

Project.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "CImGui"
22
uuid = "5d785b6c-b76f-510e-a07c-3070796c7e87"
33
authors = ["Yupei Qi <qiyupei@gmail.com>"]
4-
version = "6.1.0"
4+
version = "6.1.1"
55

66
[deps]
77
CEnum = "fa961155-64e5-5f13-b03f-caf6b980ea82"
@@ -27,9 +27,9 @@ CImGuiPack_jll = "0.10.0"
2727
CSyntax = "0.4"
2828
DocStringExtensions = "0.9.3"
2929
GLFW = "3"
30-
GLMakie = "0.10.6, 0.12, 0.13"
30+
GLMakie = "0.13"
3131
ModernGL = "1"
3232
PrecompileTools = "1.2.1"
3333
Printf = "1"
3434
Statistics = "1"
35-
julia = "1.9"
35+
julia = "1.10"

docs/src/_changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ CurrentModule = CImGui
66
This documents notable changes in CImGui.jl. The format is based on [Keep a
77
Changelog](https://keepachangelog.com).
88

9+
## [v6.1.1] - 2025-09-27
10+
11+
### Fixed
12+
- Fixed compatibility with Makie 0.24/GLMakie 0.13 and Julia 1.12 ([#180]). This
13+
required bumping the minimum support Julia version to 1.10.
14+
915
## [v6.1.0] - 2025-07-30
1016

1117
### Changed

ext/MakieIntegration.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ function ig.MakieFigure(title_id::String, f::GLMakie.Figure;
160160
resize!(f, new_size[1], new_size[2])
161161
end
162162

163+
GLMakie.poll_updates(imfigure.screen)
163164
do_render = GLMakie.requires_update(imfigure.screen)
164165
if do_render
165166
idx = mod1(imfigure.times_idx, length(imfigure.render_times))

gen/generator.jl

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ function imgui_to_jl_type(ig_type)
102102
[:(NTuple{2})]
103103
elseif parsed_type === :ImVec4
104104
[:(NTuple{4})]
105-
elseif getproperty(bindings_module, parsed_type) in (Cint, Cuint)
105+
elseif @invokelatest(getproperty(bindings_module, parsed_type)) in (Cint, Cuint)
106106
[:Integer]
107107
elseif endswith(string(parsed_type), "Callback")
108108
# Allow passing CFunctions and Ptr{Cvoid}'s to callback arguments
@@ -119,7 +119,7 @@ function imgui_to_jl_type(ig_type)
119119
# Note that we have to use getproperty() and catch an exception because
120120
# `bindings_module` is an anonymous module, for which propertynames()
121121
# doesn't work as usual.
122-
getproperty(bindings_module, enum_type)
122+
@invokelatest getproperty(bindings_module, enum_type)
123123
pushfirst!(unions, enum_type)
124124
catch ex
125125
if !(ex isa UndefVarError)
@@ -572,6 +572,13 @@ function generate()
572572
$(w.docstring)
573573
\"\"\"
574574
""")
575+
576+
# If the function name is exported from Base then we need to explicitly
577+
# declare a new function with `function` to avoid warnings on 1.12+.
578+
if Base.isexported(Base, Symbol(w.name))
579+
write(io, "function $(w.name) end\n")
580+
end
581+
575582
write(io, string(w.expr), "\n\n")
576583
end
577584

lib/aarch64-apple-darwin20.jl

Lines changed: 121 additions & 1 deletion
Large diffs are not rendered by default.

lib/aarch64-linux-gnu.jl

Lines changed: 121 additions & 1 deletion
Large diffs are not rendered by default.

lib/aarch64-linux-musl.jl

Lines changed: 121 additions & 1 deletion
Large diffs are not rendered by default.

lib/armv7l-linux-gnueabihf.jl

Lines changed: 121 additions & 1 deletion
Large diffs are not rendered by default.

lib/armv7l-linux-musleabihf.jl

Lines changed: 121 additions & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)