Cannot get GLFW version in compiled apps?

[sairus7]

When I run CImGui julia app compiled with PackageCompiler, I get the following error:

Unhandled Task ERROR: MethodError: no method matching isless(::VersionNumber, ::Nothing)
The function `isless` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  isless(::Missing, ::Any)
   @ Base missing.jl:87
  isless(::Any, ::Missing)
   @ Base missing.jl:88
  ...

Stacktrace:
 [1] <(x::VersionNumber, y::Nothing)
   @ Base .\operators.jl:353
 [2] <=(x::VersionNumber, y::Nothing)
   @ Base .\operators.jl:402
 [3] >=(x::Nothing, y::VersionNumber)
   @ Base .\operators.jl:426
 [4] renderloop(ui::MkpVerifyGUI.var"#2#3"{Bool, @Kwargs{}}, ctx::Ptr{CImGui.lib.ImGuiContext}, ::Val{:GlfwOpenGL3}; hotloading::Bool, on_exit::Function, clear_color::Vector{Float32}, window_size::Tuple{Int64, Int64}, window_title::String, engine::Nothing, opengl_version::VersionNumber, wait_events::Bool)
   @ GlfwOpenGLBackend C:\Users\skv\.julia\packages\CImGui\DazpG\ext\GlfwOpenGLBackend.jl:65
 [5] renderloop
   @ C:\Users\skv\.julia\packages\CImGui\DazpG\ext\GlfwOpenGLBackend.jl:56 [inlined]
 [6] (::GlfwOpenGLBackend.var"#5#6"{@Kwargs{wait_events::Bool, window_size::Tuple{Int64, Int64}, window_title::String, engine::Nothing, on_exit::MkpVerifyGUI.var"#5#6"{Ptr{ImPlot.ImPlotContext}}}, Tuple{MkpVerifyGUI.var"#2#3"{Bool, @Kwargs{}}, Ptr{CImGui.lib.ImGuiContext}, Val{:GlfwOpenGL3}}})()
   @ GlfwOpenGLBackend C:\Users\skv\.julia\packages\CImGui\DazpG\ext\GlfwOpenGLBackend.jl:212
ERROR: TaskFailedException

Looks like pkgversion returns nothing in this case:

if pkgversion(GLFW) >= v"3.4.4"

https://github.com/JuliaImGui/CImGui.jl/blob/v5.1.2/ext/GlfwOpenGLBackend.jl#L65

[JamesWrigley]

Looks like there are some cases where it can return nothing but I have no idea why using PackageCompiler would trigger it 🤔
https://github.com/JuliaLang/julia/blob/ad6e4bbd68bd2243217fcd72f866ad4ef13bee24/base/loading.jl#L609-L621

I'd be ok with bumping the minimum GLFW version to 3.4.4 if you want to make a PR for it.

[sairus7]

I'm not sure, maybe it looks at runtime for Project.toml from GLFW.jl package, that is not bundled by PackageCompiler. I see only main Project.toml that does not include versions for each deps.

I think the workaround here is to write version into global variable, so it is executed at module precompilation, not at runtime.

[FaresX]

I have also encountered this issue. And I think the cause is exactly what you mentioned. So I have built a compiling script to hard- code the package versions and give up on the pkgversion function

const JLD2VERSION = v"$(pkgversion(JLD2))"

[sairus7]

@FaresX are you sure interpolation actually needed? Why not just

const JLD2VERSION = pkgversion(JLD2)

by the way interpolation does not work for version string macro, so it should be like this:

const GLFW_VERSION = VersionNumber("$(pkgversion(GLFW))")

[FaresX]

Sorry for the confusion caused by my previous replies.

To clarify, the version information is not collected at runtime. Instead, before compilation, I generate the file src/Utilities/FileInfo.jl by writing the following code:

open("src/Utilities/FileInfo.jl", "w") do file
    write(
        file,
        """
        const QINSCONTROLVERSION = v"$(pkgversion(QInsControl))"
        const JLD2VERSION = v"$(pkgversion(JLD2))"

        let
            jlverinfobuf = IOBuffer()
            versioninfo(jlverinfobuf)
            jlverinfo = String(take!(jlverinfobuf))
            global function fileinfo()
                OrderedDict(
                    "QInsControl version" => QINSCONTROLVERSION,
                    "JLD2 version" => JLD2VERSION,
                    "Julia version" => jlverinfo
                )
            end
        end
        """
    )
end

Therefore, all version information is interpolated into the source code as strings at file-generation time, rather than being queried dynamically later.
If the code is not compiled, the original implementation is:

const QINSCONTROLVERSION = pkgversion(QInsControl)
const JLD2VERSION = pkgversion(JLD2)

as you just mentioned

[sairus7]

I think global constants are evaluated at precompilation time and baked with their so objects, so pkgversion is not called at runtime after compilation. Will check that.

[sairus7]

@FaresX FYI const JLD2VERSION = pkgversion(JLD2) works with compiled apps in a portable way. I've checked that with PackageCompiler on Windows.