Fix property handling for linkedpropertylistener and cache

Author: nHackel

src/RecoPlans/Cache.jl

@@ -92,7 +92,9 @@ function loadPlan!(plan::RecoPlan{<:ProcessResultCache}, dict::Dict{String, Any}
     param = loadPlan!(dict["param"], modDict)
     parent!(param, plan)
   end
-  setvalues!(plan; param, cache, maxsize)
+  setproperty!(plan, :maxsize, maxsize)
+  setproperty!(plan, :cache, cache)
+  setproperty!(plan, :param, param)
   return plan
 end
 

src/RecoPlans/LinkedPropertyListener.jl

@@ -38,7 +38,7 @@ function toDictValue!(dict, value::LinkedPropertyListener)
   dict["fn"] = toDict(value.fn)
 end
 
-function loadListener!(::Type{LinkedPropertyListener}, target::RecoPlan, targetProp, dict, args...)
+function loadListener!(::Type{LinkedPropertyListener}, target::RecoPlan, targetProp, dict, modDict)
   # Find the root plan
   root = parent(target)
   while !isnothing(parent(root))
@@ -48,7 +48,7 @@ function loadListener!(::Type{LinkedPropertyListener}, target::RecoPlan, targetP
   # From the root plan, find the source plan
   source = root
   for param in dict["plan"][1:end]
-    source = getproperty(plan, Symbol(param))
+    source = getproperty(source, Symbol(param))
   end
   sourceProp = Symbol(dict["field"])
 

src/RecoPlans/Serialization.jl

@@ -59,7 +59,12 @@ loadPlan(m::Module, name::AbstractString, modules::Vector{Module}) = loadPlan(pl
 Load a `RecoPlan` from a TOML file. The `modules` argument is a vector of modules that contain the types used in the plan.
 After loading the plan, the listeners are attached to the properties using `loadListener!`.
 """
-function loadPlan(filename::Union{AbstractString, IO}, modules::Vector{Module})
+function loadPlan(filename::String, modules)
+  open(filename) do io
+    return loadPlan(io, modules)
+  end
+end
+function loadPlan(filename::IO, modules::Vector{Module})
   dict = TOML.parse(filename)
   modDict = createModuleDataTypeDict(modules)
   plan = loadPlan!(dict, modDict)
@@ -189,7 +194,7 @@ function loadListeners!(root::RecoPlan, plan::RecoPlan{T}, dict, modDict) where
     end
   end
   for property in propertynames(plan)
-    value = plan[property]
+    value = getproperty(plan, property)
     if value isa RecoPlan
       loadListeners!(root, value, dict[string(property)], modDict)
     end
@@ -201,7 +206,7 @@ export loadListener
 
 Load a listener from `dict` and attach it to property `name` of `plan`
 """
-function loadListener!(plan,  name::Symbol, dict, modDict)
+function loadListener!(plan, name::Symbol, dict, modDict)
   type = tomlType(dict, modDict)
   return loadListener!(type, plan, name, dict, modDict)
 end