You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: src/RecoPlans/RecoPlans.jl
+4-2Lines changed: 4 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -74,7 +74,6 @@ function setvalue!(plan::RecoPlan{T}, name::Symbol, x::X) where {T, X}
74
74
75
75
t =type(plan, name)
76
76
ifvalidvalue(plan, t, x)
77
-
X <:t|| X <:RecoPlan{<:t}||ismissing(x)
78
77
getfield(plan, :values)[name] = x
79
78
else
80
79
getfield(plan, :values)[name] =convert(t, x)
@@ -93,6 +92,9 @@ end
93
92
validvalue(plan, t, value::Missing) =true
94
93
validvalue(plan, ::Type{T}, value::X) where {T, X <:T} =true
95
94
validvalue(plan, ::Type{T}, value::RecoPlan{<:T}) where T =true
95
+
# RecoPlans are stripped of parameters
96
+
validvalue(plan, t::UnionAll, ::RecoPlan{T}) where T = T <:t|| T <:Base.typename(t).wrapper # Last case doesnt work for Union{...} that is a UnionAll, such as ProcessCache Unio
0 commit comments