add error methods for unsupported NA borders

Author: IanButterworth

src/imfilter.jl

@@ -955,6 +955,21 @@ end
 planned_fft(A::AbstractArray, kernel, border::AbstractString) = planned_fft(A, kernel, borderinstance(border))
 planned_fft(A::AbstractArray, kernel::Union{ArrayLike,Laplacian}, border::BorderSpecAny) = planned_fft(A, factorkernel(kernel), border)
 
+# Error methods for NA borders - these should not be used with planned FFT
+function planned_fft(A::AbstractArray{T,N},
+            kernel::ProcessedKernel,
+            border::NA) where {T,N}
+    throw(ArgumentError("NA borders are not supported with planned FFT algorithms."))
+end
+
+function planned_fft(A::AbstractArray,
+            kernel::Union{ArrayLike,Laplacian},
+            border::NA)
+    throw(ArgumentError("NA borders are not supported with planned FFT algorithms."))
+end
+
+planned_fft(A::AbstractArray, kernel, border::NA) = throw(ArgumentError("NA borders are not supported with planned FFT algorithms."))
+
 # Unified filtfft function for planned FFT operations
 function filtfft(A::AbstractArray{T}, krn, planned_rfft1::Function, planned_rfft2::Function, planned_irfft::Function) where {T}
     if T <: Colorant

test/2d.jl

@@ -449,3 +449,18 @@ end
     @test filtfft(C, D) ≈ filtfft(C, ComplexF32.(D))
     @test filtfft(C, D) ≈ filtfft(ComplexF32.(C), ComplexF32.(D))
 end
+
+@testset "Planned FFT with NA borders should error" begin
+    imgf = zeros(Float64, 5, 7); imgf[3,4] = 1.0
+    imgi = zeros(Int, 5, 7); imgi[3,4] = 1
+    imgc = fill(RGB{Float64}(0,0,0), 5, 7); imgc[3,4] = RGB{Float64}(1,0,0)
+    kernel = OffsetArray([0.1 0.2; 0.4 0.5], -1:0, 1:2)
+    na_border = NA()
+
+    @test_throws ArgumentError planned_fft(imgf, kernel, na_border)
+    @test_throws ArgumentError planned_fft(imgi, kernel, na_border)
+    @test_throws ArgumentError planned_fft(imgc, kernel, na_border)
+    kern_tuple = (OffsetArray([0.2, 0.8], -1:0), OffsetArray([0.3 0.6], 0:0, 1:2))
+    @test_throws ArgumentError planned_fft(imgf, kern_tuple, na_border)
+    @test_throws ArgumentError planned_fft(imgf, Kernel.Laplacian(), na_border)
+end