Skip to content

Conversation

@jwahlstrand
Copy link
Collaborator

@jwahlstrand jwahlstrand commented Sep 1, 2025

The ColorTypes function gray doesn't accept integers greater than 1 now, so handle integer matrices differently, maintaining the old behavior of clamping values greater than 1.

Also fix another broken test where promote_type returns Any instead of Union{}.

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (acaab89) to head (0cbe779).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/ImageView.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   84.75%   82.62%   -2.14%     
==========================================
  Files           6        9       +3     
  Lines         866      892      +26     
==========================================
+ Hits          734      737       +3     
- Misses        132      155      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jwahlstrand jwahlstrand merged commit e03ab12 into master Sep 1, 2025
16 of 17 checks passed
@jwahlstrand jwahlstrand deleted the jw/fixtests branch September 1, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants