Skip to content

Commit ee9434c

Browse files
committed
Remove 0.4 support, and related cleanup
1 parent 2808870 commit ee9434c

File tree

5 files changed

+11
-39
lines changed

5 files changed

+11
-39
lines changed

REQUIRE

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
julia 0.4
2-
Compat 0.9.5
1+
julia 0.5
32
DataStructures
43
@windows WinReg

src/JavaCall.jl

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,16 @@ export JavaObject, JavaMetaClass,
66
getname, listmethods, getreturntype, getparametertypes
77

88
using Base.Dates
9-
using Compat
10-
import Compat.String
9+
1110
import DataStructures: OrderedSet
1211

1312
@static if is_windows()
1413
using WinReg
1514
end
1615

1716

18-
import Base.convert, Base.isnull, Base.unsafe_convert
19-
20-
# if VERSION < v"0.5.0-dev+4612"
21-
# const unsafe_string = Base.bytestring
22-
# else
23-
# const unsafe_string = Base.unsafe_string
24-
# end
17+
import Base.convert, Base.isnull, Base.unsafe_convert, Base.unsafe_string
2518

26-
if VERSION < v"0.5.0-dev+4612"
27-
import Compat.unsafe_string
28-
else
29-
import Base.unsafe_string
30-
end
3119

3220
include("jnienv.jl")
3321
include("jvm.jl")

src/convert.jl

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ for (x, y, z) in [ (:jboolean, :(jnifunc.GetBooleanArrayElements), :(jnifunc.Rel
106106
function convert_result(rettype::Type{Array{$(x),1}}, result)
107107
sz = ccall(jnifunc.GetArrayLength, jint, (Ptr{JNIEnv}, Ptr{Void}), penv, result)
108108
arr = ccall($(y), Ptr{$(x)}, (Ptr{JNIEnv}, Ptr{Void}, Ptr{jboolean} ), penv, result, C_NULL )
109-
jl_arr::Array = unsafe_wrap(Array, arr, (@compat Int(sz)), false)
109+
jl_arr::Array = unsafe_wrap(Array, arr, Int(sz), false)
110110
jl_arr = deepcopy(jl_arr)
111111
ccall($(z), Void, (Ptr{JNIEnv},Ptr{Void}, Ptr{$(x)}, jint), penv, result, arr, 0)
112112
return jl_arr
@@ -183,20 +183,6 @@ function unsafe_string(jstr::JString) #jstr must be a jstring obtained via a JN
183183
return s
184184
end
185185

186-
#This is necessary to properly deprecate bytestring in 0.5, while ensuring
187-
# callers don't need to change for 0.4.
188-
if VERSION <= v"0.5.0"
189-
function Base.bytestring(jstr::JString) #jstr must be a jstring obtained via a JNI call
190-
if VERSION >= v"0.5.0-dev+4612"
191-
Base.depwarn("bytestring(jstr::JString) is deprecated. Use unsafe_string(jstr) instead", :bytestring )
192-
end
193-
return JavaCall.unsafe_string(jstr)
194-
end
195-
end
196-
197-
198-
199-
200186
for (x, y, z) in [ (:jboolean, :(jnifunc.GetBooleanArrayElements), :(jnifunc.ReleaseBooleanArrayElements)),
201187
(:jchar, :(jnifunc.GetCharArrayElements), :(jnifunc.ReleaseCharArrayElements)),
202188
(:jbyte, :(jnifunc.GetByteArrayElements), :(jnifunc.ReleaseByteArrayElements)),
@@ -209,7 +195,7 @@ for (x, y, z) in [ (:jboolean, :(jnifunc.GetBooleanArrayElements), :(jnifunc.Rel
209195
function convert(::Type{Array{$(x),1}}, obj::JObject)
210196
sz = ccall(jnifunc.GetArrayLength, jint, (Ptr{JNIEnv}, Ptr{Void}), penv, obj.ptr)
211197
arr = ccall($(y), Ptr{$(x)}, (Ptr{JNIEnv}, Ptr{Void}, Ptr{jboolean} ), penv, obj.ptr, C_NULL )
212-
jl_arr::Array = unsafe_wrap(Array, arr, (@compat Int(sz)), false)
198+
jl_arr::Array = unsafe_wrap(Array, arr, Int(sz), false)
213199
jl_arr = deepcopy(jl_arr)
214200
ccall($(z), Void, (Ptr{JNIEnv},Ptr{Void}, Ptr{$(x)}, jint), penv, obj.ptr, arr, 0)
215201
return jl_arr

src/core.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const jshort = Cshort
1414
const jfloat = Cfloat
1515
const jdouble = Cdouble
1616
const jsize = jint
17-
jprimitive = @compat Union{jboolean, jchar, jshort, jfloat, jdouble, jint, jlong}
17+
jprimitive = Union{jboolean, jchar, jshort, jfloat, jdouble, jint, jlong}
1818

1919
immutable JavaMetaClass{T}
2020
ptr::Ptr{Void}
@@ -94,10 +94,10 @@ function JString(str::AbstractString)
9494
end
9595

9696
# jvalue(v::Integer) = int64(v) << (64-8*sizeof(v))
97-
jvalue(v::Integer) = @compat Int64(v)
97+
jvalue(v::Integer) = Int64(v)
9898
jvalue(v::Float32) = jvalue(reinterpret(Int32, v))
9999
jvalue(v::Float64) = jvalue(reinterpret(Int64, v))
100-
jvalue(v::Ptr) = jvalue(@compat Int(v))
100+
jvalue(v::Ptr) = jvalue(Int(v))
101101

102102

103103

src/reflect.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ function getclass(obj::JavaObject)
44
end
55

66
function conventional_name(name::AbstractString)
7-
if @compat startswith(name, "[")
7+
if startswith(name, "[")
88
return conventional_name(name[2:end]) * "[]"
99
elseif name == "Z"
1010
return "boolean"
@@ -22,7 +22,7 @@ function conventional_name(name::AbstractString)
2222
return "double"
2323
elseif name == "V"
2424
return "void"
25-
elseif @compat startswith(name, "L")
25+
elseif startswith(name, "L")
2626
return name[2:end-1]
2727
else
2828
return name
@@ -123,7 +123,7 @@ Returns the parameter types of the java method
123123
* method: The java method object
124124
125125
### Returns
126-
Vector the parametertypes
126+
Vector the parametertypes
127127
"""
128128
function getparametertypes(method::JMethod)
129129
jcall(method, "getParameterTypes", Vector{JClass}, ())
@@ -136,4 +136,3 @@ function Base.show(io::IO, method::JMethod)
136136
argtypestr = join(argtypes, ", ")
137137
print(io, "$rettype $name($argtypestr)")
138138
end
139-

0 commit comments

Comments
 (0)