Skip to content

Commit fb877e5

Browse files
committed
Rename jl_function_t* to jl_value_t*
Ref: JuliaLang/julia#59216
1 parent 8b3490b commit fb877e5

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

.github/workflows/test-linux-mac.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
CXXFLAGS=-ftemplate-backtrace-limit=0 cmake -DCMAKE_INSTALL_PREFIX=$HOME/install -DAPPEND_OVERRIDES_TOML=ON -DCMAKE_BUILD_TYPE=Debug ..
6060
VERBOSE=ON cmake --build . --config Debug --target install
6161
wget https://github.com/JuliaRegistries/General/raw/refs/heads/master/jll/L/libcxxwrap_julia_jll/Versions.toml
62-
jllversion=$(grep '\["' Versions.toml | tail -n 1 | sed -E 's/\["([0-9]+\.[0-9]+\.[0-9]+)\+[^"]*"\]/\1/g')
62+
jllversion=0.14.2 #$(grep '\["' Versions.toml | tail -n 1 | sed -E 's/\["([0-9]+\.[0-9]+\.[0-9]+)\+[^"]*"\]/\1/g')
6363
cd lib
6464
if [ ! -f libcxxwrap_julia.${jllversion}.dylib ]; then
6565
ln -s libcxxwrap_julia.*.*.*.* libcxxwrap_julia.${jllversion}.dylib

examples/functions.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -274,28 +274,28 @@ JLCXX_MODULE init_test_module(jlcxx::Module& mod)
274274
JL_GC_POP();
275275
});
276276

277-
mod.method("fn_clb2", [] (jl_function_t* f)
277+
mod.method("fn_clb2", [] (jl_value_t* f)
278278
{
279279
std::vector<double> v{1., 2.};
280280
auto ar = jlcxx::ArrayRef<double, 1>(v.data(), v.size());
281281
jlcxx::JuliaFunction fnClb(f);
282282
fnClb((jl_value_t*)ar.wrapped(), std::wstring(L"calledFromCPP"));
283283
});
284284

285-
mod.method("callback_byval", [] (jl_function_t* f, int& result)
285+
mod.method("callback_byval", [] (jl_value_t* f, int& result)
286286
{
287287
jlcxx::JuliaFunction juliafunc(f);
288288
juliafunc(BoxedNumber(1), result);
289289
});
290290

291-
mod.method("callback_byref", [] (jl_function_t* f, int& result)
291+
mod.method("callback_byref", [] (jl_value_t* f, int& result)
292292
{
293293
jlcxx::JuliaFunction juliafunc(f);
294294
BoxedNumber n(2);
295295
juliafunc(n, result);
296296
});
297297

298-
mod.method("callback_byptr", [] (jl_function_t* f, int& result)
298+
mod.method("callback_byptr", [] (jl_value_t* f, int& result)
299299
{
300300
jlcxx::JuliaFunction juliafunc(f);
301301
BoxedNumber n(3);

examples/inheritance.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,12 @@ class VirtualCppJuliaExtended : public VirtualCpp
107107
return sum;
108108
}
109109

110-
void set_callback(jl_function_t* callback)
110+
void set_callback(jl_value_t* callback)
111111
{
112112
m_callback = callback;
113113
}
114114
private:
115-
jl_function_t* m_callback = nullptr;
115+
jl_value_t* m_callback = nullptr;
116116
};
117117

118118
class VirtualCfunctionExtended : public VirtualCpp

include/jlcxx/functions.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ class JLCXX_API JuliaFunction
1919
/// Construct using a function name and module name. Searches the current module by default. Throws if the function was not found.
2020
JuliaFunction(const std::string& name, const std::string& module_name = "");
2121
/// Construct directly from a pointer (throws if pointer is null)
22-
JuliaFunction(jl_function_t* fpointer);
22+
JuliaFunction(jl_value_t* fpointer);
2323

2424
/// Access to the raw pointer
25-
jl_function_t* pointer() const
25+
jl_value_t* pointer() const
2626
{
2727
return m_function;
2828
}
@@ -61,7 +61,7 @@ class JLCXX_API JuliaFunction
6161
jl_value_t** m_arg_array;
6262
int m_i = 0;
6363
};
64-
jl_function_t* m_function;
64+
jl_value_t* m_function;
6565
};
6666

6767
template<typename... ArgumentsT>

include/jlcxx/module.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ struct UpCast
137137
};
138138

139139
// The CxxWrap Julia module
140-
extern jl_module_t* g_cxxwrap_module;
140+
extern JLCXX_API jl_module_t* g_cxxwrap_module;
141141
extern jl_datatype_t* g_cppfunctioninfo_type;
142142

143143
class JLCXX_API Module;
@@ -704,7 +704,7 @@ class JLCXX_API Module
704704
auto labels_jl = ArrayRef<const char*>(&labels[0], nb_items);
705705
auto values_jl = ArrayRef<T>(&values[0], nb_items);
706706

707-
jl_function_t* add_enum_fn = jl_get_function(g_cxxwrap_module, "add_enum");
707+
jl_value_t* add_enum_fn = jl_get_function(g_cxxwrap_module, "add_enum");
708708
if(add_enum_fn == nullptr)
709709
{
710710
throw std::runtime_error("CxxWrapCore.add_enum function not found, ensure you are using at least CxxWrap 0.17.3");

src/functions.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ JuliaFunction::JuliaFunction(const std::string& name, const std::string& module_
3838
}
3939
}
4040

41-
JuliaFunction::JuliaFunction(jl_function_t* fpointer)
41+
JuliaFunction::JuliaFunction(jl_value_t* fpointer)
4242
{
4343
if(fpointer == nullptr)
4444
{

src/jlcxx.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ cxx_gc_roots_t& cxx_gc_roots()
1515
return m_roots;
1616
}
1717

18-
jl_module_t* g_cxxwrap_module = nullptr;
18+
JLCXX_API jl_module_t* g_cxxwrap_module = nullptr;
1919
jl_datatype_t* g_cppfunctioninfo_type = nullptr;
2020

2121
JLCXX_API void protect_from_gc(jl_value_t* v)

0 commit comments

Comments
 (0)