Improve tests

Author: OlivierHnt

src/intervals/arithmetic/basic.jl

@@ -255,10 +255,11 @@ Square root of an interval.
 Implement the `sqrt` function of the IEEE Std 1788-2015 (Table 9.1).
 """
 function sqrt(a::F) where {F<:Interval}
-    domain = F(0, Inf)
+    G = float(F)
+    domain = G(0, Inf)
     a = a ∩ domain
 
     isempty(a) && return a
 
-    return @round(F, sqrt(inf(a)), sqrt(sup(a)))  # `sqrt` is correctly-rounded
+    return @round(G, sqrt(inf(a)), sqrt(sup(a)))  # `sqrt` is correctly-rounded
 end

test/display_tests/display.jl

@@ -66,17 +66,17 @@ let x, b
     end
 
     @testset "Interval{Rational{T}}" begin
-        a = interval(1//3, 5//4)
-        @test_broken typeof(a) == Interval{Rational{Int}}
+        a = Interval{Rational{Int64}}(1//3, 5//4)
+        @test typeof(a) == Interval{Rational{Int}}
 
         setformat(:standard)
-        @test_broken sprint(show, MIME("text/plain"), a) == "[1//3, 5//4]"
+        @test sprint(show, MIME("text/plain"), a) == "[1//3, 5//4]"
 
         setformat(:full)
-        @test_broken sprint(show, MIME("text/plain"), a) == "Interval{Rational{Int}}(1//3, 5//4)"
+        @test sprint(show, MIME("text/plain"), a) == "Interval{Rational{Int64}}(1//3, 5//4)"
 
         setformat(:midpoint)
-        @test_broken sprint(show, MIME("text/plain"), a) == "19//24 ± 11//24"
+        @test sprint(show, MIME("text/plain"), a) == "19//24 ± 11//24"
     end
 
     @testset "Interval{Float32}" begin

test/interval_tests/consistency.jl

@@ -67,7 +67,9 @@ using Test
         @test fma(zero(a), entireinterval(), b) ≛ b
         @test fma(one(a), entireinterval(), b) ≛ entireinterval()
         @test fma(a, zero(a), c) ≛ c
-        @test_broken fma(interval(1//2), interval(1//3), interval(1//12)) ≛ interval(3//12)
+        @test fma(Interval{Rational{Int}}(1//2, 1//2),
+            Interval{Rational{Int}}(1//3, 1//3),
+            Interval{Rational{Int}}(1//12, 1//12)) ≛ Interval{Rational{Int}}(3//12, 3//12)
     end
 
     @testset "∈ tests" begin
@@ -182,7 +184,7 @@ using Test
     end
 
     @testset "mid" begin
-        @test mid(interval(1//2)) == 1//2
+        @test mid(interval(Rational{Int}, 1//2)) == 1//2
         @test mid(1..2) == 1.5
         @test mid(0.1..0.3) == 0.2
         @test mid(-10..5) == -2.5
@@ -206,7 +208,7 @@ using Test
     end
 
     @testset "diam" begin
-        @test diam( interval(1//2) ) == 0//1
+        @test diam( interval(Rational{Int}, 1//2) ) == 0//1
         @test diam( @interval(1//10) ) == eps(0.1)
         @test diam( @interval(0.1) ) == 2eps(0.1)
         @test isnan(diam(emptyinterval()))
@@ -217,10 +219,10 @@ using Test
 
     @testset "mig and mag" begin
         @test mig(@interval(-2,2)) == BigFloat(0.0)
-        @test mig( interval(1//2) ) == 1//2
+        @test mig( interval(Rational{Int}, 1//2) ) == 1//2
         @test isnan(mig(emptyinterval()))
         @test mag(-b) == b.hi
-        @test mag( interval(1//2) ) == 1//2
+        @test mag( interval(Rational{Int}, 1//2) ) == 1//2
         @test isnan(mag(emptyinterval()))
     end
 
@@ -262,7 +264,7 @@ using Test
     end
 
     @testset "mid and radius" begin
-        @test radius(interval(-1//10,1//10)) == diam(interval(-1//10,1//10))/2
+        @test radius(interval(Rational{Int}, -1//10,1//10)) == diam(interval(Rational{Int}, -1//10,1//10))/2
         @test isnan(IntervalArithmetic.radius(emptyinterval()))
         @test mid(c) == 2.125
         @test isnan(mid(emptyinterval()))
@@ -334,7 +336,7 @@ using Test
 
     @testset "isthinzero" begin
         @test isthinzero(interval(0))
-        @test isthinzero(interval(0//1))
+        @test isthinzero(interval(Rational{Int}, 0//1))
         @test isthinzero(interval(big(0)))
         @test isthinzero(interval(-0.0))
         @test isthinzero(interval(-0.0, 0.0))

test/interval_tests/construction.jl

@@ -9,10 +9,9 @@ using Test
         interval(Float64, interval(1.0))
     @test size(interval(1)) == ()  # Match the `size` behaviour of `Number`
     @test interval(big(1)) ≛ Interval{Float64}(1.0, 1.0)
-    @test_broken interval(1//10) ≛ Interval{Rational{Int}}(1//10, 1//10)
-    @test_broken interval(BigInt(1)//10) ≛ Interval{Rational{BigInt}}(1//10, 1//10)
+    @test interval(Rational{Int}, 1//10) ≛ Interval{Rational{Int}}(1//10, 1//10)
+    @test_broken interval(Rational{BigInt}, BigInt(1)//10) ≛ Interval{Rational{BigInt}}(1//10, 1//10)
     @test interval( (1.0, 2.0) ) ≛ Interval{Float64}(1.0, 2.0)
-    @test_broken interval(Rational{Int}, 1) ≛ interval(1//1)
     @test interval(BigFloat, 1) ≛ Interval{BigFloat}(big(1.0), big(1.0))
 
     # Irrational

test/interval_tests/non_BigFloat.jl

@@ -2,12 +2,12 @@ using IntervalArithmetic
 using Test
 
 @testset "Tests with rational intervals" begin
-    a = interval(1//2, 3//4)
-    b = interval(3//7, 9//12)
+    a = interval(Rational{Int}, 1//2, 3//4)
+    b = interval(Rational{Int}, 3//7, 9//12)
 
-    @test a + b ≛ interval(13//14, 3//2)  # exact
+    @test a + b ≛ interval(Rational{Int}, 13//14, 3//2)  # exact
 
-    @test sqrt(a + b) ≛ interval(0.9636241116594314, 1.2247448713915892)
+    @test sqrt(a + b) ≛ interval(0.9636241116594315, 1.2247448713915892)
 
     X = interval(1//3)
     @test sqrt(X) ≛ interval(0.5773502691896257, 0.5773502691896258)

test/interval_tests/numeric.jl

@@ -46,8 +46,8 @@ end
                 $f(interval(Float64, pi), Interval{Float64}(interval(Float32, pi)))
         end
     end
-    @test interval(1//4,1//2) + interval(2//3) ≛ interval(11//12, 7//6)
-    @test_broken interval(1//4,1//2) - interval(2//3) ≛ interval(-5//12, -1//6)
+    @test interval(Rational{Int}, 1//4, 1//2) + interval(Rational{Int}, 2//3) ≛ interval(Rational{Int}, 11//12, 7//6)
+    @test interval(Rational{Int}, 1//4, 1//2) - interval(Rational{Int}, 2//3) ≛ interval(Rational{Int}, -5//12, -1//6)
 
     @test interval(-30.0,-15.0) / interval(-5.0,-3.0) ≛ interval(3.0, 10.0)
     @test interval(-30,-15) / interval(-5,-3) ≛ interval(3.0, 10.0)