Cleanup

Author: OlivierHnt

src/intervals/arithmetic/basic.jl

@@ -239,9 +239,11 @@ Implement the `sqrt` function of the IEEE Standard 1788-2015 (Table 9.1).
 """
 function Base.sqrt(x::BareInterval{T}) where {T<:AbstractFloat}
     sup(x) < 0 && return emptyinterval(BareInterval{T})
-    lo = inf(x) < 0 ? zero(T) : inf(x)
+    lo = _cut_negative_domain(x)
     return @round(T, sqrt(lo), sqrt(sup(x)))
 end
+_cut_negative_domain(x::BareInterval{T}) where {T<:AbstractFloat} = ifelse(inf(x) < 0, zero(T), inf(x))
+_cut_negative_domain(x::BareInterval{T}) where {T<:BigFloat} = inf(x) < 0 ? zero(T) : inf(x)
 
 Base.sqrt(x::BareInterval{<:Rational}) = sqrt(float(x))
 

src/intervals/construction.jl

@@ -78,8 +78,8 @@ Internal constructor which assumes that `is_valid_interval(lo, hi) == true`.
 _unsafe_bareinterval(::Type{T}, a, b) where {T<:NumTypes} =
     _unsafe_bareinterval(T, _round(T, a, RoundDown), _round(T, b, RoundUp))
 
-_normalisezero(a) = ifelse(iszero(a), zero(a), a)  # Avoid branch in general
-_normalisezero(a::BigFloat) = iszero(a) ? zero(a) : a  # For BigFloat we avoid the allocation as much as possible
+_normalisezero(a) = ifelse(iszero(a), zero(a), a)
+_normalisezero(a::BigFloat) = iszero(a) ? zero(a) : a # avoid allocation for BigFloat
 # used only to construct intervals; needed to avoid `inf` and `sup` normalization
 _inf(x::BareInterval) = x.lo
 _sup(x::BareInterval) = x.hi

src/intervals/interval_operations/numeric.jl

@@ -14,8 +14,9 @@ Implement the `inf` function of the IEEE Standard 1788-2015 (Table 9.2).
 See also: [`sup`](@ref), [`bounds`](@ref), [`mid`](@ref), [`diam`](@ref),
 [`radius`](@ref) and [`midradius`](@ref).
 """
-function inf(x::BareInterval{T}) where {T<:AbstractFloat}
-    isnan(x.lo) && return typemax(T)
+inf(x::BareInterval{T}) where {T<:AbstractFloat} = ifelse(isnan(x.lo), typemax(T), ifelse(iszero(x.lo), copysign(x.lo, -1), x.lo))
+function inf(x::BareInterval{T}) where {T<:BigFloat}
+    isnan(x.lo) && return typemax(T) # typemax(x.lo)
     iszero(x.lo) && return copysign(x.lo, -1)
     return x.lo
 end
@@ -43,8 +44,9 @@ Implement the `sup` function of the IEEE Standard 1788-2015 (Table 9.2).
 See also: [`inf`](@ref), [`bounds`](@ref), [`mid`](@ref), [`diam`](@ref),
 [`radius`](@ref) and [`midradius`](@ref).
 """
-function sup(x::BareInterval{T}) where {T<:AbstractFloat}
-    isnan(x.hi) && return typemin(T)
+sup(x::BareInterval{T}) where {T<:AbstractFloat} = ifelse(isnan(x.hi), typemin(T), x.hi)
+function sup(x::BareInterval{T}) where {T<:BigFloat}
+    isnan(x.hi) && return typemin(T) # typemin(x.hi)
     return x.hi
 end