Simplify and test instruction predicate getter. (#473)

Author: maleadt

src/core/instructions.jl

@@ -1,6 +1,5 @@
 export Instruction, remove!, erase!, parent,
-       opcode,
-       predicate_int, predicate_real
+       opcode
 
 # forward definition of Instruction in src/core/value/constant.jl
 register(Instruction, API.LLVMInstructionValueKind)
@@ -76,9 +75,11 @@ end
 
 ## comparisons
 
-predicate_int(inst::ICmpInst) = API.LLVMGetICmpPredicate(inst)
+export predicate
 
-predicate_real(inst::FCmpInst) = API.LLVMGetFCmpPredicate(inst)
+predicate(inst::ICmpInst) = API.LLVMGetICmpPredicate(inst)
+
+predicate(inst::FCmpInst) = API.LLVMGetFCmpPredicate(inst)
 
 
 ## atomics

src/deprecated.jl

@@ -36,6 +36,9 @@ Base.@deprecate_binding ValueMetadataDict LLVM.InstructionMetadataDict
 @deprecate unsafe_delete!(::Function, bb::BasicBlock) erase!(bb)
 @deprecate unsafe_delete!(::BasicBlock, inst::Instruction) erase!(inst)
 
+@deprecate predicate_int(inst) predicate(inst)
+@deprecate predicate_real(inst) predicate(inst)
+
 @deprecate Base.string(md::MDString) convert(String, md) false
 function Base.show(io::IO, ::MIME"text/plain", md::MDString)
     str = @invoke string(md::Metadata)

test/instructions_tests.jl

@@ -351,9 +351,11 @@
 
     icmpinst = icmp!(builder, LLVM.API.LLVMIntEQ, int1, int2)
     @check_ir icmpinst "icmp eq i32 %0, %1"
+    @test predicate(icmpinst) == LLVM.API.LLVMIntEQ
 
     fcmpinst = fcmp!(builder, LLVM.API.LLVMRealOEQ, float1, float2)
     @check_ir fcmpinst "fcmp oeq float %2, %3"
+    @test predicate(fcmpinst) == LLVM.API.LLVMRealOEQ
 
     phiinst = phi!(builder, LLVM.Int32Type())
     @check_ir phiinst "phi i32 "