Merge pull request #151 from maleadt/tb/flags_setindex

Use setindex for setting module flags.

Author: maleadt

src/core/module.jl

@@ -200,7 +200,9 @@ function Base.getindex(iter::ModuleFlagDict, name::String)
     return Metadata(objref)
 end
 
-Base.push!(iter::ModuleFlagDict, behavior::LLVM.API.LLVMModuleFlagBehavior, name::String, val::Metadata) =
+function Base.setindex!(iter::ModuleFlagDict, val::Metadata,
+                        (name, behavior)::Tuple{String, LLVM.API.LLVMModuleFlagBehavior})
     API.LLVMAddModuleFlag(ref(iter.mod), behavior, name, length(name), ref(val))
+end
 
 end

test/core.jl

@@ -533,7 +533,7 @@ LLVM.Module("SomeModule", ctx) do mod
         md = Metadata(ConstantInt(42, ctx))
 
         mod_flags = flags(mod)
-        push!(mod_flags, LLVM.API.LLVMModuleFlagBehaviorError, "foobar", md)
+        mod_flags["foobar", LLVM.API.LLVMModuleFlagBehaviorError] = md
 
         @test occursin("!llvm.module.flags = !{!0}", sprint(io->show(io,mod)))
         @test occursin(r"!0 = !\{i\d+ 1, !\"foobar\", i\d+ 42\}", sprint(io->show(io,mod)))