Merge pull request #310 from maleadt/tb/unnamed_struct

Support querying an unnamed struct's name.

Author: maleadt

.github/workflows/ci.yml

@@ -6,56 +6,63 @@ on:
   pull_request:
   workflow_dispatch:
 jobs:
-  test:
-    name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ matrix.libLLVMExtra }} libLLVMExtra - assertions=${{ matrix.assertions }}
+  binary_test:
+    name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
         version: ['1.6', '1.7', '^1.8.0-beta3', 'nightly']
         os: [ubuntu-latest, macOS-latest, windows-latest]
         arch: [x64]
-        libLLVMExtra: [packaged]
-        assertions: [false]
-        include:
-          # special test with a locally-built libLLVMExtra
-          - os: ubuntu-latest
-            arch: x64
-            libLLVMExtra: local
-            version: '1.7'
-            assertions: true
-          # special test with LLVM assertions enabled
-          # TODO: enable this across all versions
-          #       (needs LLVM.jl fixes, and julia-actions/setup-julia support)
-          - os: ubuntu-latest
-            arch: x64
-            libLLVMExtra: packaged
-            version: '1.7'
-            assertions: true
-          - os: ubuntu-latest
-            arch: x64
-            libLLVMExtra: packaged
-            version: '1.8'
-            assertions: true
     steps:
       - uses: actions/checkout@v2
-      # install Julia
       - uses: julia-actions/setup-julia@v1
-        if: ${{ ! matrix.assertions }}
         with:
           version: ${{ matrix.version }}
           arch: ${{ matrix.arch }}
-      - name: Download Julia with assertions
-        if: ${{ matrix.assertions }}
+      - uses: actions/cache@v1
         env:
-          version: ${{ matrix.version }}
-          arch: ${{ matrix.arch }}
+          cache-name: cache-artifacts
+        with:
+          path: ~/.julia/artifacts
+          key: ${{ runner.os }}-test-${{ env.cache-name }}-${{ hashFiles('**/Project.toml') }}
+          restore-keys: |
+            ${{ runner.os }}-test-${{ env.cache-name }}-
+            ${{ runner.os }}-test-
+            ${{ runner.os }}-
+      - uses: julia-actions/julia-buildpkg@v1
+      - name: Run tests
+        run: |
+          julia --project -e 'using Pkg; Pkg.test(; coverage=true, julia_args=`-g2`)'
+      - uses: julia-actions/julia-processcoverage@v1
+      - uses: codecov/codecov-action@v1
+        with:
+          file: lcov.info
+
+  # development versions of Julia, built with assertions enabled.
+  # we also build LLVMExtra from source here.
+  source_test:
+    name: Julia ${{ matrix.branch }} - ${{ matrix.os }} - ${{ matrix.arch }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        branch: ['release-1.7', 'release-1.8', 'master']
+        os: [ubuntu-latest, macOS-latest]
+        arch: [x64]
+        assertions: [false]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
+        with:
+          repository: 'JuliaLang/julia'
+          ref: ${{ matrix.branch }}
+          path: 'julia'
+      - name: Compile Julia
         run: |
-          wget https://julialangnightlies.s3.amazonaws.com/assert_bin/linux/$arch/$version/julia-latest-linux64.tar.gz
-          tar -xvzf julia-latest-linux64.tar.gz
-          rm -rf julia-latest-linux64.tar.gz
-          echo $PWD/julia-*/bin >> $GITHUB_PATH
-      # prepare
+          make -C julia -j $(nproc) FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 JULIA_PRECOMPILE=0
+          echo $PWD/julia/usr/bin >> $GITHUB_PATH
       - uses: actions/cache@v1
         env:
           cache-name: cache-artifacts
@@ -68,19 +75,17 @@ jobs:
             ${{ runner.os }}-
       - uses: julia-actions/julia-buildpkg@v1
       - name: Build libLLVMExtra
-        if: ${{ matrix.libLLVMExtra == 'local' }}
         run: |
           julia --project=deps -e 'using Pkg; Pkg.instantiate()'
           julia --project=deps deps/build_local.jl
-      # test
       - name: Run tests
         run: |
           julia --project -e 'using Pkg; Pkg.test(; coverage=true, julia_args=`-g2`)'
-      # process results
       - uses: julia-actions/julia-processcoverage@v1
       - uses: codecov/codecov-action@v1
         with:
           file: lcov.info
+
   docs:
     name: Documentation
     runs-on: ubuntu-latest

src/core/type.jl

@@ -193,8 +193,10 @@ end
 StructType(elems::Vector{<:LLVMType}; packed::Core.Bool=false, ctx::Context) =
     StructType(API.LLVMStructTypeInContext(ctx, elems, length(elems), convert(Bool, packed)))
 
-name(structtyp::StructType) =
-    unsafe_string(API.LLVMGetStructName(structtyp))
+function name(structtyp::StructType)
+    cstr = API.LLVMGetStructName(structtyp)
+    cstr == C_NULL ? nothing : unsafe_string(cstr)
+end
 ispacked(structtyp::StructType) =
     convert(Core.Bool, API.LLVMIsPackedStruct(structtyp))
 isopaque(structtyp::StructType) =

test/core.jl

@@ -122,6 +122,7 @@ end
         @test context(st) == ctx
         @test !ispacked(st)
         @test !isopaque(st)
+        @test name(st) === nothing
 
         let elem_it = elements(st)
             @test eltype(elem_it) == LLVMType