Disallow sizeof queries on LLVM values and types.

Author: maleadt

src/core/type.jl

@@ -4,6 +4,9 @@ export LLVMType, issized, context, show
 abstract type LLVMType end
 
 Base.eltype(typ::LLVMType) = Any
+Base.sizeof(typ::LLVMType) = error("LLVM types are not sized")
+# TODO: expose LLVMSizeOf/LLVMAlignOf, yielding run-time values?
+# XXX: can we query type sizes from the data layout or target?
 
 Base.unsafe_convert(::Type{API.LLVMTypeRef}, typ::LLVMType) = typ.ref
 

src/core/value.jl

@@ -37,14 +37,16 @@ function Value(ref::API.LLVMValueRef)
 end
 
 
-
 ## general APIs
 
 export llvmtype, llvmeltype, name, name!, replace_uses!, replace_metadata_uses!, isconstant, isundef, ispoison, context
 
 llvmtype(val::Value) = LLVMType(API.LLVMTypeOf(val))
 llvmeltype(val::Value) = eltype(llvmtype(val))
 
+# defer size queries to the LLVM type (where we'll error)
+Base.sizeof(val::Value) = sizeof(llvmtype(val))
+
 name(val::Value) = unsafe_string(API.LLVMGetValueName(val))
 name!(val::Value, name::String) = API.LLVMSetValueName(val, name)
 

test/core.jl

@@ -48,6 +48,7 @@ end
 
     @test issized(LLVM.Int1Type(ctx))
     @test !issized(LLVM.VoidType(ctx))
+    @test_throws ErrorException sizeof(typ)
 end
 
 # integer
@@ -216,6 +217,7 @@ end
     show(devnull, val)
 
     @test llvmtype(val) == LLVM.PointerType(typ)
+    @test_throws ErrorException sizeof(val)
     @test name(val) == "foo"
     @test !isconstant(val)
     @test !isundef(val)