Refactor in anticipation of breaking release #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
changed the title
|
As suggested by @gbaraldi, I'm also deprecating the untyped instruction build methods. Note that I think I managed to do so in a non-breaking way, so it'll be possible to backport all this to a 4.x release (only the ConstantData change was breaking, necessitating v5.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #152 introducing
DIBuilder, we shouldn't have a generically-namedBuilder. Now that we're breaking things, let's rename this toIRBuilder.I did add a deprecation to not make this breaking right away, as well as added deprecations for
llvmtypeandllvmeltype; no reason to make this release extra painful.