Skip to content

Commit 0f3f09f

Browse files
committed
Drop compat for axes #435 and #442
1 parent 8d22dd0 commit 0f3f09f

File tree

4 files changed

+5
-15
lines changed

4 files changed

+5
-15
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,6 @@ Currently, the `@compat` macro supports the following syntaxes:
152152

153153
* `reprmime(mime, x)` is now `repr(mime, x)` ([#25990]) and `mimewritable` is now `showable` ([#26089]).
154154

155-
* `indices` is now `axes` ([#25057]). This function is not exported from Compat to avoid
156-
conflicts with AxisArrays and other such packages.
157-
158155
* `Void` is now `Nothing` with an alias `Cvoid` for C interop ([#25162]).
159156

160157
* `Base.IteratorSize` and `Base.IteratorEltype` are available as

src/Compat.jl

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,6 @@ end
4646

4747
include("compatmacro.jl")
4848

49-
# 0.7.0-DEV.2978
50-
@static if !isdefined(Base, :axes)
51-
const axes = Base.indices
52-
# NOTE: Intentionally not exported to avoid conflicts with AxisArrays
53-
#export axes
54-
end
55-
5649
# 0.7.0-DEV.3137
5750
@static if !isdefined(Base, :Nothing)
5851
const Nothing = Void

test/old.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -572,3 +572,8 @@ end
572572

573573
# 0.7.0-DEV.2951
574574
@test AbstractDict === (isdefined(Base, :AbstractDict) ? Base.AbstractDict : Base.Associative)
575+
576+
# 0.7.0-DEV.2978
577+
@test Compat.axes === (isdefined(Base, :axes) ? Base.axes : Base.indices)
578+
@test Compat.axes(1) == ()
579+
@test Compat.axes(1,1) == 1:1

test/runtests.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@ let A = [1]
8080
@test x == 1
8181
end
8282

83-
# 0.7.0-DEV.2978
84-
@test Compat.axes === (isdefined(Base, :axes) ? Base.axes : Base.indices)
85-
@test Compat.axes(1) == ()
86-
@test Compat.axes(1,1) == 1:1
87-
8883
# 0.7.0-DEV.3137
8984
@test Nothing === (isdefined(Base, :Nothing) ? Base.Nothing : Base.Void)
9085
@test Nothing === Cvoid

0 commit comments

Comments
 (0)