Skip to content

Commit 19735ae

Browse files
committed
Mark Compat.Printf from #435 for deprecation
1 parent ff6f907 commit 19735ae

File tree

4 files changed

+11
-19
lines changed

4 files changed

+11
-19
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ Currently, the `@compat` macro supports the following syntaxes:
5858
* `using Compat.Unicode` is provided on versions older than 0.7, where this library is not
5959
yet a part of the standard library. ([#25021])
6060

61-
* `using Compat.Printf` is provided on versions older than 0.7, where this library is not
62-
yet a part of the standard library. ([#25056])
63-
6461
* `using Compat.SparseArrays` is provided on versions older than 0.7, where this library is
6562
not yet part of the standard library ([#25249]).
6663

src/Compat.jl

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,11 @@ import Test, SharedArrays, Mmap, DelimitedFiles
2323
import Dates
2424
import Libdl
2525
const AbstractDateTime = Compat.Dates.AbstractDateTime
26+
import Printf
2627

2728

2829
include("compatmacro.jl")
2930

30-
if VERSION < v"0.7.0-DEV.3052"
31-
const Printf = Base.Printf
32-
else
33-
import Printf
34-
end
35-
3631
if VERSION < v"0.7.0-DEV.2655"
3732
@eval module IterativeEigensolvers
3833
using Base: eigs, svds

test/old.jl

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,16 @@ end
107107
@test Compat.AbstractDateTime <: Compat.Dates.TimeType
108108
@test Compat.Dates.DateTime <: Compat.AbstractDateTime
109109

110+
# 0.7
111+
module Test25056
112+
using Compat
113+
using Compat.Test
114+
using Compat.Printf
115+
@test isdefined(@__MODULE__, :Printf)
116+
@test isdefined(@__MODULE__, Symbol("@printf"))
117+
@test isdefined(@__MODULE__, Symbol("@sprintf"))
118+
end
119+
110120

111121
# tests of removed functionality (i.e. justs tests Base)
112122

test/runtests.jl

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,6 @@ if VERSION < v"0.7.0-DEV.880"
7272
end
7373
end
7474

75-
# 0.7
76-
module Test25056
77-
using Compat
78-
using Compat.Test
79-
using Compat.Printf
80-
@test isdefined(@__MODULE__, :Printf)
81-
@test isdefined(@__MODULE__, Symbol("@printf"))
82-
@test isdefined(@__MODULE__, Symbol("@sprintf"))
83-
end
84-
8575
# 0.7
8676

8777
let a = [0,1,2,3,0,1,2,3]

0 commit comments

Comments
 (0)