Skip to content

Commit b3deb13

Browse files
committed
Mark Compat.Libdl from #465 (and #467) for deprecation
1 parent 75b8411 commit b3deb13

File tree

4 files changed

+9
-17
lines changed

4 files changed

+9
-17
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ Currently, the `@compat` macro supports the following syntaxes:
7070
* `using Compat.Random` is provided on versions older than 0.7, where this library is
7171
not yet part of the standard library ([#24874]).
7272

73-
* `using Compat.Libdl` is provided on versions older than 0.7, where this library is
74-
not yet part of the standard library ([#25459]).
75-
7673
* `using Compat.REPL` is provided on versions older than 0.7, where this library is
7774
not yet part of the standard library ([#25544]).
7875

src/Compat.jl

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,11 @@ end
2121
import Base.MathConstants
2222
import Test, SharedArrays, Mmap, DelimitedFiles
2323
import Dates
24+
import Libdl
2425

2526

2627
include("compatmacro.jl")
2728

28-
if VERSION < v"0.7.0-DEV.3382"
29-
const Libdl = Base.Libdl
30-
else
31-
import Libdl
32-
end
33-
3429
# https://github.com/JuliaLang/julia/pull/24182
3530
if VERSION < v"0.7.0-DEV.2402"
3631
const ConvertiblePeriod = Union{Compat.Dates.TimePeriod, Compat.Dates.Week, Compat.Dates.Day}

test/old.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,14 @@ module Test24459
9494
@test isdefined(@__MODULE__, :Dates)
9595
end
9696

97+
# 0.7.0-DEV.3382
98+
module TestLibdl
99+
using Compat
100+
using Compat.Libdl
101+
using Compat.Test
102+
@test isdefined(@__MODULE__, :Libdl)
103+
end
104+
97105

98106
# tests of removed functionality (i.e. justs tests Base)
99107

test/runtests.jl

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -412,14 +412,6 @@ end
412412
@test nameof(Float64) == :Float64
413413
@test nameof(Array) == :Array
414414

415-
# 0.7.0-DEV.3382
416-
module TestLibdl
417-
using Compat
418-
using Compat.Libdl
419-
using Compat.Test
420-
@test isdefined(@__MODULE__, :Libdl)
421-
end
422-
423415
# 0.7.0-DEV.3516
424416
@test argmax([10,12,9,11]) == 2
425417
@test argmax([10 12; 9 11]) == CartesianIndex(1, 2)

0 commit comments

Comments
 (0)