add Aqua tests (disabled on buildkite)

Author: IanButterworth

Project.toml

@@ -8,8 +8,9 @@ Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
 Sockets = "6462fe0b-24de-5631-8697-dd941f90decc"
 
 [extras]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["LinearAlgebra", "Test"]
+test = ["Aqua", "LinearAlgebra", "Test"]

test/aqua.jl

@@ -0,0 +1,9 @@
+using Aqua
+using Distributed
+
+Aqua.test_all(
+    Distributed,
+    # This should be excluded, but it's not clear how to do that on Aqua's API
+    # given it's not-defined. (The Julia Base ambiguity test does it something like this)
+    # ambiguities=(exclude=[GlobalRef(Distributed, :cluster_manager)])
+)

test/runtests.jl

@@ -3,6 +3,12 @@
 using Test
 using Distributed
 
+if !Base.get_bool_env("BUILDKITE", false)
+    @testset "Aqua.jl tests" begin
+        include("aqua.jl")
+    end
+end
+
 allowed_undefineds = Set([GlobalRef(Distributed, :cluster_manager)])
 @test isempty(detect_ambiguities(Distributed; allowed_undefineds))