Skip to content

Commit 94de3a2

Browse files
committed
Fix JET errors regarding the global cluster_manager being defined/undefined
``` ┌ @ Distributed /workpath/Distributed.jl/src/process_messages.jl:319 │ `Distributed.cluster_manager` may be undefined: Distributed.cluster_manager └──────────────────── ┌ @ Distributed /workpath/Distributed.jl/src/process_messages.jl:332 │ `Distributed.cluster_manager` may be undefined: Distributed.cluster_manager └──────────────────── ``` We know that the global `cluster_manager` is defined, because it was defined in the `init_worker(...)` function. This commit fixes the JET error.
1 parent 79b4ca8 commit 94de3a2

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/process_messages.jl

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,8 +315,12 @@ function handle_msg(msg::ResultMsg, header, r_stream, w_stream, version)
315315
end
316316

317317
function handle_msg(msg::IdentifySocketMsg, header, r_stream, w_stream, version)
318+
# We know that the global `Distributed.cluster_manager` is defined, because it was defined
319+
# in the `init_worker(...)` function.
320+
@assert isdefined(Distributed, :cluster_manager) # fixes a JET warning
321+
318322
# register a new peer worker connection
319-
w = Worker(msg.from_pid, r_stream, w_stream, cluster_manager; version=version)::Worker
323+
w = Worker(msg.from_pid, r_stream, w_stream, Distributed.cluster_manager; version=version)::Worker
320324
send_connection_hdr(w, false)
321325
send_msg_now(w, MsgHeader(), IdentifySocketAckMsg())
322326
notify(w.initialized)
@@ -328,8 +332,12 @@ function handle_msg(msg::IdentifySocketAckMsg, header, r_stream, w_stream, versi
328332
end
329333

330334
function handle_msg(msg::JoinPGRPMsg, header, r_stream, w_stream, version)
335+
# We know that the global `cluster_manager` is defined, because it was defined
336+
# in the `init_worker(...)` function.
337+
@assert isdefined(Distributed, :cluster_manager) # fixes a JET warning
338+
331339
LPROC.id = msg.self_pid
332-
controller = Worker(1, r_stream, w_stream, cluster_manager; version=version)::Worker
340+
controller = Worker(1, r_stream, w_stream, Distributed.cluster_manager; version=version)::Worker
333341
notify(controller.initialized)
334342
register_worker(LPROC)
335343
topology(msg.topology)

0 commit comments

Comments
 (0)