Skip to content

Commit 08aecd6

Browse files
committed
Re-enable JET in the tests
And fix an issue found by the latest version.
1 parent aaa37ba commit 08aecd6

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

docs/src/_changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@ Changelog](https://keepachangelog.com).
99

1010
## Unreleased
1111

12+
### Changed
13+
- Replaced JSON.jl with a vendored copy of
14+
[JSONX](https://github.com/JuliaIO/JSON.jl/tree/master/vendor) ([#1200]). This
15+
lets us remove one more dependency and remove all of the invalidations caused
16+
by JSON.jl. Load time is also slightly improved, from ~0.08s to ~0.05s on
17+
Julia 1.12.
18+
1219
## [v1.31.1] - 2025-10-20
1320

1421
### Added

src/inline.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ for mime in ipy_mime
7373
@eval begin
7474
function display(d::InlineDisplay, ::MIME{Symbol($mime)}, x)
7575
kernel = _default_kernel
76+
if isnothing(kernel)
77+
error("Kernel has not been instantiated, cannot display.")
78+
end
79+
7680
flush_all() # so that previous stream output appears in order
7781
send_ipython(kernel.publish[], kernel,
7882
msg_pub(kernel.execute_msg, "display_data",

test/jsonx.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ import IJulia: JSONX
252252

253253
@testset "AbstractVector{UInt8} Support" begin
254254
@test JSONX.parse(Vector{UInt8}("null")) === nothing
255-
@test JSONX.parse(Vector{UInt8}("42")) === 42
255+
@test JSONX.parse(Vector{UInt8}("42")) === Int64(42)
256256
@test JSONX.parse(Vector{UInt8}("\"hello\"")) == "hello"
257257
@test JSONX.parse(Vector{UInt8}("[1,2,3]")) == [1, 2, 3]
258258
@test JSONX.parse(Vector{UInt8}("{\"a\":1}")) == Dict("a" => 1)

test/runtests.jl

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ end
2424
Aqua.test_all(IJulia; stale_deps=(; ignore=[:Pkg, :Conda]))
2525
end
2626

27-
# Temporarily disabled because JET doesn't seem to play well with JSON v1
28-
# @testset "JET.jl" begin
29-
# JET.test_package(IJulia; target_defined_modules=true)
30-
# end
27+
@testset "JET.jl" begin
28+
JET.test_package(IJulia; target_modules=(IJulia,))
29+
end

0 commit comments

Comments
 (0)