Merge pull request #1143 from JuliaLang/aqua

Add Aqua to the test suite

Author: JamesWrigley

.github/workflows/CI.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        julia-version: ['1.6', '1']
+        julia-version: ['1.10', '1']
         julia-arch: [x64]
         os: [ubuntu-latest, windows-latest, macOS-13]
         include:

Project.toml

@@ -8,7 +8,6 @@ Conda = "8f4d0f93-b110-5947-807f-2305c1781a2d"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
 JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
-Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
 Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
 Markdown = "d6f4376e-aef5-505a-96c1-9c027394607a"
 MbedTLS = "739be429-bea8-5141-9913-cc70e7f3736d"
@@ -17,14 +16,23 @@ Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 SoftGlobalScope = "b85f4697-e234-5449-a836-ec8e2f98b302"
-Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 ZMQ = "c2297ded-f4af-51ae-bb23-16f91089e4e1"
 
 [compat]
+Base64 = "1"
 Conda = "1"
+Dates = "1"
+InteractiveUtils = "1"
 JSON = "0.18,0.19,0.20,0.21,1"
+Logging = "1"
+Markdown = "1"
 MbedTLS = "0.5,0.6,0.7,1"
+Pkg = "1"
+Printf = "1"
+REPL = "1"
+Random = "1"
 SoftGlobalScope = "1"
+UUIDs = "1"
 ZMQ = "1.3"
 julia = "1.10"

src/heartbeat.jl

@@ -4,8 +4,6 @@
 # call in libzmq, which simply blocks forever, so the usual lack of
 # thread safety in Julia should not be an issue here.
 
-import Libdl
-
 const threadid = zeros(Int, 128) # sizeof(uv_thread_t) <= 8 on Linux, OSX, Win
 
 # entry point for new thread

test/Project.toml

@@ -0,0 +1,6 @@
+[deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
+Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
+JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

test/runtests.jl

@@ -1,9 +1,14 @@
+import Aqua
+import IJulia
+
 const TEST_FILES = [
     "install.jl", "comm.jl", "msg.jl", "execute_request.jl", "stdio.jl",
-    "inline.jl",
+    "inline.jl"
 ]
 
 for file in TEST_FILES
     println(file)
     include(file)
 end
+
+Aqua.test_all(IJulia; piracies=(; broken=true))