Fix incomplete_tag generation with trailing whitespace (#518)

Previously we relied on the last SyntaxNode consuming all trailing
whitespace when detecting incomplete syntax. However this assumption was
broken by #397 and is generally fragile with respect to any extra
bump_trivia() calls. Fix this by just comparing to the stream position
before any bumping of remaining trivia.

Author: c42f

src/hooks.jl

@@ -173,13 +173,14 @@ function core_parser_hook(code, filename::String, lineno::Int, offset::Int, opti
             end
         end
         parse!(stream; rule=options)
+        pos_before_trivia = last_byte(stream)
         if options === :statement
             bump_trivia(stream)
         end
 
         if any_error(stream)
             tree = build_tree(SyntaxNode, stream, first_line=lineno, filename=filename)
-            tag = _incomplete_tag(tree, lastindex(code))
+            tag = _incomplete_tag(tree, pos_before_trivia)
             if _has_v1_10_hooks
                 exc = ParseError(stream, filename=filename, first_line=lineno,
                                  incomplete_tag=tag)

test/hooks.jl

@@ -171,6 +171,9 @@ end
                 "1, "          => :other
                 "1,\n"         => :other
                 "1, \n"        => :other
+                "f(1, "        => :other
+                "[x "          => :other
+                "( "           => :other
 
                 # Reference parser fails to detect incomplete exprs in this case
                 "(x for y"     => :other