Skip to content

Commit 23e122f

Browse files
committed
avoid extra copy
1 parent dfb1334 commit 23e122f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/bunchkaufman.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ Factorization{T}(B::BunchKaufman) where {T} = BunchKaufman{T}(B)
219219

220220
AbstractMatrix(B::BunchKaufman) = B.uplo == 'U' ? B.P'B.U*B.D*B.U'B.P : B.P'B.L*B.D*B.L'B.P
221221
AbstractArray(B::BunchKaufman) = AbstractMatrix(B)
222-
Matrix(B::BunchKaufman) = Array(AbstractArray(B))
222+
Matrix(B::BunchKaufman) = convert(Array, AbstractArray(B))
223223
Array(B::BunchKaufman) = Matrix(B)
224224

225225

src/cholesky.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ Factorization{T}(C::CholeskyPivoted) where {T} = CholeskyPivoted{T}(C)
646646

647647
AbstractMatrix(C::Cholesky) = C.uplo == 'U' ? C.U'C.U : C.L*C.L'
648648
AbstractArray(C::Cholesky) = AbstractMatrix(C)
649-
Matrix(C::Cholesky) = Array(AbstractArray(C))
649+
Matrix(C::Cholesky) = convert(Array, AbstractArray(C))
650650
Array(C::Cholesky) = Matrix(C)
651651

652652
function AbstractMatrix(F::CholeskyPivoted)
@@ -655,7 +655,7 @@ function AbstractMatrix(F::CholeskyPivoted)
655655
U'U
656656
end
657657
AbstractArray(F::CholeskyPivoted) = AbstractMatrix(F)
658-
Matrix(F::CholeskyPivoted) = Array(AbstractArray(F))
658+
Matrix(F::CholeskyPivoted) = convert(Array, AbstractArray(F))
659659
Array(F::CholeskyPivoted) = Matrix(F)
660660

661661
copy(C::Cholesky) = Cholesky(copy(C.factors), C.uplo, C.info)

0 commit comments

Comments
 (0)