Add a special path for strided matrices

Author: jishnub

src/adjtrans.jl

@@ -319,8 +319,8 @@ const AdjointAbsVec{T} = Adjoint{T,<:AbstractVector}
 const AdjointAbsMat{T} = Adjoint{T,<:AbstractMatrix}
 const TransposeAbsVec{T} = Transpose{T,<:AbstractVector}
 const TransposeAbsMat{T} = Transpose{T,<:AbstractMatrix}
-const AdjOrTransAbsVec{T} = AdjOrTrans{T,<:AbstractVector}
-const AdjOrTransAbsMat{T} = AdjOrTrans{T,<:AbstractMatrix}
+const AdjOrTransAbsVec{T,V<:AbstractVector} = AdjOrTrans{T,V}
+const AdjOrTransAbsMat{T,M<:AbstractMatrix} = AdjOrTrans{T,M}
 
 # for internal use below
 wrapperop(_) = identity

src/diagonal.jl

@@ -332,14 +332,29 @@ function (*)(D::Diagonal, V::AbstractVector)
     return D.diag .* V
 end
 
-function (*)(A::AdjOrTransAbsMat, D::Diagonal)
+function _diag_adj_mul(A::AdjOrTransAbsMat, D::Diagonal)
     adj = wrapperop(A)
     copy(adj(adj(D) * adj(A)))
 end
-function (*)(D::Diagonal, A::AdjOrTransAbsMat)
+function _diag_adj_mul(A::AdjOrTransAbsMat{<:Any, <:StridedMatrix}, D::Diagonal)
+    Ac = copy_similar(A, promote_op(*, eltype(A), eltype(D)))
+    rmul!(Ac, D)
+end
+function _diag_adj_mul(D::Diagonal, A::AdjOrTransAbsMat)
     adj = wrapperop(A)
     copy(adj(adj(A) * adj(D)))
 end
+function _diag_adj_mul(D::Diagonal, A::AdjOrTransAbsMat{<:Any, <:StridedMatrix})
+    Ac = copy_similar(A, promote_op(*, eltype(A), eltype(D)))
+    lmul!(D, Ac)
+end
+
+function (*)(A::AdjOrTransAbsMat, D::Diagonal)
+    _diag_adj_mul(A, D)
+end
+function (*)(D::Diagonal, A::AdjOrTransAbsMat)
+    _diag_adj_mul(D, A)
+end
 
 function rmul!(A::AbstractMatrix, D::Diagonal)
     matmul_size_check(size(A), size(D))