Skip to content

Commit d1c35e6

Browse files
committed
simplified the rtol default eps call in rank(::QRPivoted)
1 parent c4aa5f3 commit d1c35e6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/qr.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ function ldiv!(A::QRCompactWY{T}, B::AbstractMatrix{T}) where {T}
535535
return B
536536
end
537537

538-
function rank(A::QRPivoted; atol::Real=0, rtol::Real=min(size(A)...) * eps(real(float(one(eltype(A.Q))))) * iszero(atol))
538+
function rank(A::QRPivoted; atol::Real=0, rtol::Real=min(size(A)...) * eps(real(float(eltype(A.Q)))) * iszero(atol))
539539
m = min(size(A)...)
540540
m == 0 && return 0
541541
tol = max(atol, rtol*abs(A.factors[1,1]))

0 commit comments

Comments
 (0)