Add bounds-check tests

Author: jishnub

test/bidiag.jl

@@ -1184,6 +1184,9 @@ end
     B[LinearAlgebra.BandIndex(-1,1)] = 2
     @test B[2,1] == 2
     @test_throws "cannot set entry $((3,1)) off the lower bidiagonal band" B[LinearAlgebra.BandIndex(-2,1)] = 2
+
+    @test_throws BoundsError B[LinearAlgebra.BandIndex(size(B,1),1)]
+    @test_throws BoundsError B[LinearAlgebra.BandIndex(0,size(B,1)+1)]
 end
 
 end # module TestBidiagonal

test/diagonal.jl

@@ -1485,7 +1485,9 @@ end
     D = Diagonal(zeros(2))
     D[LinearAlgebra.BandIndex(0,2)] = 1
     @test D[2,2] == 1
-    @test_throws "cannot set off-diagonal entry" D[LinearAlgebra.BandIndex(1,1)] = 1
+    @test_throws "cannot set off-diagonal entry $((1,2))" D[LinearAlgebra.BandIndex(1,1)] = 1
+    @test_throws BoundsError D[LinearAlgebra.BandIndex(size(D,1),1)]
+    @test_throws BoundsError D[LinearAlgebra.BandIndex(0,size(D,1)+1)]
 end
 
 end # module TestDiagonal

test/tridiag.jl

@@ -1173,12 +1173,16 @@ end
 
     @test_throws "cannot set entry $((1,3)) off the tridiagonal band" T[LinearAlgebra.BandIndex(2,1)] = 1
     @test_throws "cannot set entry $((3,1)) off the tridiagonal band" T[LinearAlgebra.BandIndex(-2,1)] = 1
+    @test_throws BoundsError T[LinearAlgebra.BandIndex(size(T,1),1)]
+    @test_throws BoundsError T[LinearAlgebra.BandIndex(0,size(T,1)+1)]
 
     S = SymTridiagonal(zeros(4), zeros(3))
     S[LinearAlgebra.BandIndex(0,2)] = 1
     @test S[2,2] == 1
 
     @test_throws "cannot set off-diagonal entry $((1,3))" S[LinearAlgebra.BandIndex(2,1)] = 1
+    @test_throws BoundsError S[LinearAlgebra.BandIndex(size(S,1),1)]
+    @test_throws BoundsError S[LinearAlgebra.BandIndex(0,size(S,1)+1)]
 end
 
 end # module TestTridiagonal