CartesianIndex to BandIndex

Author: jishnub

src/LinearAlgebra.jl

@@ -517,6 +517,12 @@ function _torowcol(b::BandIndex)
 end
 CartesianIndex(b::BandIndex) = CartesianIndex{2}(b)
 CartesianIndex{2}(b::BandIndex) = CartesianIndex{2}(_torowcol(b))
+function BandIndex(c::CartesianIndex{2})
+    row, col = Tuple(c)
+    band = col - row
+    index = min(row, col)
+    BandIndex(band, index)
+end
 function Base.to_indices(A, inds, t::Tuple{BandIndex, Vararg})
     to_indices(A, inds, (_torowcol(first(t))..., Base.tail(t)...))
 end

test/special.jl

@@ -762,6 +762,12 @@ end
         end
         @test_throws BoundsError D[BandIndex(size(D,1),1)]
     end
+    @testset "BandIndex to CartesianIndex" begin
+        b = BandIndex(1, 2)
+        c = CartesianIndex(b)
+        @test c == CartesianIndex(2, 3)
+        @test BandIndex(c) == b
+    end
 end
 
 @testset "Partly filled Hermitian and Diagonal algebra" begin