Rename to _sym_uplo

Author: jishnub

src/LinearAlgebra.jl

@@ -380,12 +380,12 @@ function sym_uplo(uplo::Char)
     end
 end
 """
-    sym_uplo_unsafe(uplo::Char)
+    _sym_uplo(uplo::Char)
 
 Return the `Symbol` corresponding to `uplo` without checking for validity.
 See also `sym_uplo`, which checks for validity.
 """
-sym_uplo_unsafe(uplo::Char) = uplo == 'U' ? (:U) : (:L)
+_sym_uplo(uplo::Char) = uplo == 'U' ? (:U) : (:L)
 
 @noinline throw_uplo() = throw(ArgumentError("uplo argument must be either :U (upper) or :L (lower)"))
 

src/bidiag.jl

@@ -295,7 +295,7 @@ function show(io::IO, M::Bidiagonal)
     print(io, ", ")
     show(io, M.ev)
     print(io, ", ")
-    show(io, sym_uplo_unsafe(M.uplo))
+    show(io, _sym_uplo(M.uplo))
     print(io, ")")
 end
 

src/bunchkaufman.jl

@@ -131,7 +131,7 @@ end
 
 bkcopy_oftype(A, S) = eigencopy_oftype(A, S)
 function bkcopy_oftype(A::Symmetric{<:Complex}, S)
-    Symmetric(copytrito!(similar(parent(A), S, size(A)), A.data, A.uplo), sym_uplo_unsafe(A.uplo))
+    Symmetric(copytrito!(similar(parent(A), S, size(A)), A.data, A.uplo), _sym_uplo(A.uplo))
 end
 
 """

src/special.jl

@@ -292,19 +292,19 @@ end
 
 for f in (:+, :-)
     @eval function $f(D::Diagonal{<:Number}, S::Symmetric)
-        uplo = sym_uplo_unsafe(S.uplo)
+        uplo = _sym_uplo(S.uplo)
         return Symmetric(parentof_applytri($f, Symmetric(D, uplo), S), uplo)
     end
     @eval function $f(S::Symmetric, D::Diagonal{<:Number})
-        uplo = sym_uplo_unsafe(S.uplo)
+        uplo = _sym_uplo(S.uplo)
         return Symmetric(parentof_applytri($f, S, Symmetric(D, uplo)), uplo)
     end
     @eval function $f(D::Diagonal{<:Real}, H::Hermitian)
-        uplo = sym_uplo_unsafe(H.uplo)
+        uplo = _sym_uplo(H.uplo)
         return Hermitian(parentof_applytri($f, Hermitian(D, uplo), H), uplo)
     end
     @eval function $f(H::Hermitian, D::Diagonal{<:Real})
-        uplo = sym_uplo_unsafe(H.uplo)
+        uplo = _sym_uplo(H.uplo)
         return Hermitian(parentof_applytri($f, H, Hermitian(D, uplo)), uplo)
     end
 end
@@ -608,8 +608,8 @@ end
 # tridiagonal cholesky factorization
 function cholesky(S::RealSymHermitian{<:BiTriSym}, ::NoPivot = NoPivot(); check::Bool = true)
     T = choltype(S)
-    B = Bidiagonal{T}(diag(S, 0), diag(S, S.uplo == 'U' ? 1 : -1), sym_uplo_unsafe(S.uplo))
-    cholesky!(Hermitian(B, sym_uplo_unsafe(S.uplo)), NoPivot(); check = check)
+    B = Bidiagonal{T}(diag(S, 0), diag(S, S.uplo == 'U' ? 1 : -1), _sym_uplo(S.uplo))
+    cholesky!(Hermitian(B, _sym_uplo(S.uplo)), NoPivot(); check = check)
 end
 
 # istriu/istril for triangular wrappers of structured matrices

src/symmetriceigen.jl

@@ -3,10 +3,10 @@
 # preserve HermOrSym wrapper
 # Call `copytrito!` instead of `copy_similar` to only copy the matching triangular half
 function eigencopy_oftype(A::Hermitian, ::Type{S}) where S
-    Hermitian(copytrito!(similar(parent(A), S, size(A)), A.data, A.uplo), sym_uplo_unsafe(A.uplo))
+    Hermitian(copytrito!(similar(parent(A), S, size(A)), A.data, A.uplo), _sym_uplo(A.uplo))
 end
 function eigencopy_oftype(A::Symmetric, ::Type{S}) where S
-    Symmetric(copytrito!(similar(parent(A), S, size(A)), A.data, A.uplo), sym_uplo_unsafe(A.uplo))
+    Symmetric(copytrito!(similar(parent(A), S, size(A)), A.data, A.uplo), _sym_uplo(A.uplo))
 end
 eigencopy_oftype(A::Symmetric{<:Complex}, ::Type{S}) where S = copyto!(similar(parent(A), S), A)
 
@@ -318,8 +318,8 @@ end
 
 # Perform U' \ A / U in-place, where U::Union{UpperTriangular,Diagonal}
 UtiAUi!(A, U) = _UtiAUi!(A, U)
-UtiAUi!(A::Symmetric, U) = Symmetric(_UtiAUi!(copytri!(parent(A), A.uplo), U), sym_uplo_unsafe(A.uplo))
-UtiAUi!(A::Hermitian, U) = Hermitian(_UtiAUi!(copytri!(parent(A), A.uplo, true), U), sym_uplo_unsafe(A.uplo))
+UtiAUi!(A::Symmetric, U) = Symmetric(_UtiAUi!(copytri!(parent(A), A.uplo), U), _sym_uplo(A.uplo))
+UtiAUi!(A::Hermitian, U) = Hermitian(_UtiAUi!(copytri!(parent(A), A.uplo, true), U), _sym_uplo(A.uplo))
 _UtiAUi!(A, U) = rdiv!(ldiv!(U', A), U)
 
 function eigvals(A::HermOrSym{TA}, B::HermOrSym{TB}; kws...) where {TA,TB}