Skip to content

Commit fe5a63b

Browse files
Luis-Varonajishnub
andauthored
Change 'F.values' calls to 'eigvals(F)'
This commit incorporates changes suggested by @jishnub to edit all associated 'F.values'/'f.values' calls in the diff to 'eigvals(F)'/'eigvals(f)' instead. Co-authored-by: Jishnu Bhattacharya <[email protected]>
1 parent ff77b71 commit fe5a63b

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/eigen.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,8 @@ eigvecs(A::Union{Number, AbstractMatrix}; kws...) =
276276
eigvecs(F::Union{Eigen, GeneralizedEigen}) = F.vectors
277277

278278
eigvals(F::Union{Eigen, GeneralizedEigen}) = F.values
279-
eigmin(F::Union{Eigen, GeneralizedEigen}) = minimum(F.values)
280-
eigmax(F::Union{Eigen, GeneralizedEigen}) = maximum(F.values)
279+
eigmin(F::Union{Eigen, GeneralizedEigen}) = minimum(eigvals(F))
280+
eigmax(F::Union{Eigen, GeneralizedEigen}) = maximum(eigvals(F))
281281

282282
"""
283283
eigvals!(A; permute::Bool=true, scale::Bool=true, sortby) -> values

test/eigen.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ aimg = randn(n,n)/2
4545
@test isposdef(a) == isposdef(f)
4646
@test eigvals(f) === f.values
4747

48-
if all(isreal, f.values)
49-
@test eigmin(f) == minimum(f.values)
50-
@test eigmax(f) == maximum(f.values)
48+
if all(isreal, eigvals(f))
49+
@test eigmin(f) == minimum(eigvals(f))
50+
@test eigmax(f) == maximum(eigvals(f))
5151
else
5252
@test_throws MethodError eigmin(f)
5353
@test_throws MethodError eigmax(f)
@@ -91,9 +91,9 @@ aimg = randn(n,n)/2
9191
@test eigvecs(asym_sg, ASG2) == f.vectors
9292
@test eigvals(f) === f.values
9393

94-
if all(isreal, f.values)
95-
@test eigmin(f) == minimum(f.values)
96-
@test eigmax(f) == maximum(f.values)
94+
if all(isreal, eigvals(f))
95+
@test eigmin(f) == minimum(eigvals(f))
96+
@test eigmax(f) == maximum(eigvals(f))
9797
else
9898
@test_throws MethodError eigmin(f)
9999
@test_throws MethodError eigmax(f)

0 commit comments

Comments
 (0)