Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Apr 5, 2025

This adds specializations for istril(::UpperTriangular) and istriu(::LowerTriangular), and similarly for the unit triangular matrices. By forwarding the operations to the parent, we may improve performance:

julia> Z = zeros(400,400);

julia> @btime istril(UpperTriangular($Z));
  115.105 μs (0 allocations: 0 bytes) # master
  20.188 μs (0 allocations: 0 bytes) # this PR

@jishnub jishnub added arrays [a, r, r, a, y, s] performance Must go faster labels Apr 5, 2025
@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (925acef) to head (9675c38).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   92.03%   91.97%   -0.07%     
==========================================
  Files          34       34              
  Lines       15475    15479       +4     
==========================================
- Hits        14243    14237       -6     
- Misses       1232     1242      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 3f46f5f into master Apr 6, 2025
3 of 4 checks passed
@ViralBShah ViralBShah deleted the jishnub/istriul_tri branch April 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrays [a, r, r, a, y, s] performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants