Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Apr 7, 2025

Since the symmetry check in the SymTridiagonal constructor is unnecessary if the argument is known to be symmetric from its type, we may skip it (as well as the extra allocation of the lower diagonal that is necessary for the check).

@jishnub jishnub added the arrays [a, r, r, a, y, s] label Apr 7, 2025
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.99%. Comparing base (ae5385b) to head (6cf9b4f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/symmetric.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
- Coverage   92.00%   91.99%   -0.02%     
==========================================
  Files          34       34              
  Lines       15487    15486       -1     
==========================================
- Hits        14249    14246       -3     
- Misses       1238     1240       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub force-pushed the jishnub/symtri_symmetric branch from 134cec8 to 6cf9b4f Compare April 8, 2025 03:44
@jishnub jishnub merged commit 5d3ef46 into master Apr 8, 2025
2 of 4 checks passed
@jishnub jishnub deleted the jishnub/symtri_symmetric branch April 8, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrays [a, r, r, a, y, s]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants