define lu!(F::LU,A) for general matrices #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Dec 2, 2024
stevengj
reviewed
Dec 2, 2024
stevengj
reviewed
Dec 2, 2024
stevengj
reviewed
Dec 2, 2024
Co-authored-by: Steven G. Johnson <[email protected]>
stevengj
reviewed
Dec 3, 2024
stevengj
reviewed
Dec 14, 2024
Co-authored-by: Steven G. Johnson <[email protected]>
|
Is this good to merge? |
stevengj
approved these changes
Feb 28, 2025
|
Does this go into a NEWS entry somewhere? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
+ Coverage 91.99% 92.02% +0.03%
==========================================
Files 34 34
Lines 15471 15480 +9
==========================================
+ Hits 14232 14246 +14
+ Misses 1239 1234 -5 ☔ View full report in Codecov by Sentry. |
|
We should add to the LinearAlgebra section of the Julia NEWS. |
|
The docs CI is failing. |
|
@KristofferC is this a problem? ┌ Warning: The active manifest file has dependencies that were resolved with a different julia version (1.12.0-DEV). Unexpected behavior may occur. |
jishnub
pushed a commit
that referenced
this pull request
Jun 29, 2025
It looks like #1131 was merged after the feature-freeze for 1.12, so the docstring should list the minimum version as 1.13 instead. cc @longemen3000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #1125 . Defines
lu!(F::LU{<:Any,<:AbstractMatrix},A)andlu!(F::LU{<:Any,<:StridedMatrix{<:BlasFloat}},A).closes #1125