Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Feb 23, 2025

This specialized method was missing for a SymTridiagonal. This improves performance:

julia> S = SymTridiagonal(1:4000, 1:3999);

julia> @btime $S .+ $S;
  15.217 μs (6 allocations: 62.64 KiB) # master
  3.789 μs (6 allocations: 62.64 KiB) # this PR

@jishnub jishnub added the performance Must go faster label Feb 23, 2025
Co-authored-by: Daniel Karrasch <[email protected]>
@codecov
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (579b5f7) to head (b93dc50).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          34       34           
  Lines       15384    15392    +8     
=======================================
+ Hits        14143    14151    +8     
  Misses       1241     1241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 8fdbfd5 into master Feb 23, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/symtri_bandindex branch February 23, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants