Skip to content

Forward _tri(l/r)div! to parent of triangular #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

Forward _tri(l/r)div! to parent of triangular #1348

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1bf1cd
Forward `_tri(l/r)div!` to parent of triangular
jishnub May 11, 2025
28c8eca
Scaling for partly initialized unit triangular
jishnub May 12, 2025
7a5cfca
Revert "Scaling for partly initialized unit triangular"
jishnub May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,38 +801,38 @@ function _triscale!(A::LowerOrUnitLowerTriangular, c::Number, B::UnitLowerTriang
return A
end

function _trirdiv!(A::UpperTriangular, B::UpperOrUnitUpperTriangular, c::Number)
function _trirdiv!(A::UpperTriangular, B::UpperTriangular, c::Number)
checksize1(A, B)
for j in axes(B,2)
for i in firstindex(B,1):j
@inbounds A[i, j] = B[i, j] / c
@inbounds A.data[i, j] = B.data[i, j] / c
end
end
return A
end
function _trirdiv!(A::LowerTriangular, B::LowerOrUnitLowerTriangular, c::Number)
function _trirdiv!(A::LowerTriangular, B::LowerTriangular, c::Number)
checksize1(A, B)
for j in axes(B,2)
for i in j:lastindex(B,1)
@inbounds A[i, j] = B[i, j] / c
@inbounds A.data[i, j] = B.data[i, j] / c
end
end
return A
end
function _trildiv!(A::UpperTriangular, c::Number, B::UpperOrUnitUpperTriangular)
function _trildiv!(A::UpperTriangular, c::Number, B::UpperTriangular)
checksize1(A, B)
for j in axes(B,2)
for i in firstindex(B,1):j
@inbounds A[i, j] = c \ B[i, j]
@inbounds A.data[i, j] = c \ B.data[i, j]
end
end
return A
end
function _trildiv!(A::LowerTriangular, c::Number, B::LowerOrUnitLowerTriangular)
function _trildiv!(A::LowerTriangular, c::Number, B::LowerTriangular)
checksize1(A, B)
for j in axes(B,2)
for i in j:lastindex(B,1)
@inbounds A[i, j] = c \ B[i, j]
@inbounds A.data[i, j] = c \ B.data[i, j]
end
end
return A
Expand Down