Skip to content

Commit 0ede753

Browse files
authored
Skip the incremental=false tests on Julia nightly
1 parent 1ffd504 commit 0ede753

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

test/runtests.jl

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const is_slow_ci = is_ci && Sys.ARCH == :aarch64
1818
const is_julia_1_6 = VERSION.major == 1 && VERSION.minor == 6
1919
const is_julia_1_9 = VERSION.major == 1 && VERSION.minor == 9
2020
const is_julia_1_11 = VERSION.major == 1 && VERSION.minor == 11
21+
const is_julia_1_12 = VERSION.major == 1 && VERSION.minor == 12
2122

2223
if is_ci
2324
@show Sys.ARCH
@@ -27,7 +28,14 @@ if is_slow_ci
2728
@warn "This is \"slow CI\" (`is_ci && Sys.ARCH == :aarch64`). Some tests will be skipped or modified." Sys.ARCH
2829
end
2930

30-
if any([is_julia_1_6, is_julia_1_9, is_julia_1_11])
31+
const some_tests_skipped = [
32+
is_julia_1_6,
33+
is_julia_1_9,
34+
is_julia_1_11,
35+
is_julia_1_12,
36+
]
37+
38+
if any(some_tests_skipped)
3139
@warn "This is Julia $(VERSION.major).$(VERSION.minor). Some tests will be skipped or modified." VERSION
3240
end
3341

@@ -79,10 +87,10 @@ end
7987
app_compiled_dir = joinpath(tmp, "MyAppCompiled")
8088
@testset for incremental in (is_slow_ci ? (false,) : (true, false))
8189
if incremental == false
82-
if is_julia_1_11
83-
# On Julia 1.11, `incremental=false` is currently broken: https://github.com/JuliaLang/PackageCompiler.jl/issues/976
84-
# So, for now, we skip the `incremental=false` tests on Julia 1.11
85-
@warn "This is Julia 1.11; skipping incremental=false test due to known bug: https://github.com/JuliaLang/PackageCompiler.jl/issues/976"
90+
if is_julia_1_11 || is_julia_1_12
91+
# On Julia 1.11 and 1.12, `incremental=false` is currently broken: https://github.com/JuliaLang/PackageCompiler.jl/issues/976
92+
# So, for now, we skip the `incremental=false` tests on Julia 1.11 and 1.12
93+
@warn "This is Julia $(VERSION.major).$(VERSION.minor); skipping incremental=false test due to known bug: https://github.com/JuliaLang/PackageCompiler.jl/issues/976"
8694
@test_skip false
8795
continue
8896
end

0 commit comments

Comments
 (0)