Skip to content

Commit 14f260e

Browse files
authored
Merge branch 'master' into dpa/slow-ci
2 parents ddcd9e3 + f5eba5f commit 14f260e

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

test/runtests.jl

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,23 @@ end
243243

244244
# Test creating an empty sysimage
245245
if !is_slow_ci
246-
tmp = mktempdir()
247-
sysimage_path = joinpath(tmp, "empty." * Libdl.dlext)
248-
foreach(x -> touch(joinpath(tmp, x)), ["Project.toml", "Manifest.toml"])
249-
create_sysimage(String[]; sysimage_path=sysimage_path, incremental=false, filter_stdlibs=true, project=tmp)
250-
hello = read(`$(Base.julia_cmd()) -J $(sysimage_path) -e 'print("hello, world")'`, String)
251-
@test hello == "hello, world"
246+
if is_julia_1_12
247+
# On Julia 1.12, `incremental=false` is currently broken when doing `create_library()`.
248+
# 1.12: No GitHub issue yet.
249+
# So, for now, we skip the `incremental=false` tests on Julia 1.12 when doing `create_library()`.
250+
@warn "This is Julia $(VERSION.major).$(VERSION.minor); skipping incremental=false test when doing `create_library()` due to known bug: issue TODO (for 1.12)"
251+
@test_skip false
252+
else
253+
tmp = mktempdir()
254+
sysimage_path = joinpath(tmp, "empty." * Libdl.dlext)
255+
foreach(x -> touch(joinpath(tmp, x)), ["Project.toml", "Manifest.toml"])
256+
257+
# This is why we need to skip this test on 1.12:
258+
incremental=false
259+
260+
create_sysimage(String[]; sysimage_path=sysimage_path, incremental=incremental, filter_stdlibs=true, project=tmp)
261+
hello = read(`$(Base.julia_cmd()) -J $(sysimage_path) -e 'print("hello, world")'`, String)
262+
@test hello == "hello, world"
263+
end
252264
end
253265
end

0 commit comments

Comments
 (0)