Skip to content

Commit 8e57908

Browse files
authored
Make implicit function definition (in julia_init.c) an error (#936)
This is an easy thing to get wrong. Someone more familiar with Julia than with C is not likely to recognize the significance of this error. I've also almost never seen this intentionally ignored in the wild, so I don't expect many false positives.
1 parent 41ef30d commit 8e57908

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/juliaconfig.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ end
5454

5555
function cflags()
5656
flags = IOBuffer()
57-
print(flags, "-O2 -std=gnu99")
57+
print(flags, " -Werror-implicit-function-declaration")
58+
print(flags, " -O2 -std=gnu99")
5859
include = shell_escape(julia_includedir())
5960
print(flags, " -I", include)
6061
if Sys.isunix()

0 commit comments

Comments
 (0)