add test for https://github.com/JuliaLang/julia/issues/34680 #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/absolute_path_ccall
branch
2 times, most recently
from
5606e9c to
19e52cc
Compare
KristofferC
force-pushed
the
kc/absolute_path_ccall
branch
from
19e52cc to
89355fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 83.98% 79.93% -4.05%
==========================================
Files 2 2
Lines 331 324 -7
==========================================
- Hits 278 259 -19
- Misses 53 65 +12
Continue to review full report at Codecov.
|
Member
|
Needs a rebase? |
KristofferC
force-pushed
the
kc/absolute_path_ccall
branch
2 times, most recently
from
46a1889 to
90e57b9
Compare
KristofferC
force-pushed
the
kc/absolute_path_ccall
branch
from
90e57b9 to
5bb6790
Compare
Member
|
@KristofferC Is this still needed? I took a look at the merge conflicts, but I'm not familiar enough with this PR to be able to resolve the merge conflicts quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for JuliaLang/julia#34680. This should (hopefully) fail on Windows and pass when JuliaLang/julia#34754 is merged.