Add Aqua tests. Add missing compats (#4150)

(cherry picked from commit 5e6c457)

Author: IanButterworth

Project.toml

@@ -32,4 +32,20 @@ REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb"
 REPLExt = "REPL"
 
 [compat]
+Artifacts = "1.11"
+Dates = "1.11"
+Downloads = "1.6"
+FileWatching = "1.11"
+LibGit2 = "1.11"
+Libdl = "1.11"
+Logging = "1.11"
+Markdown = "1.11"
+Printf = "1.11"
+Random = "1.11"
+REPL = "1.11"
+SHA = "0.7"
+TOML = "1"
+Tar = "1.10"
+UUIDs = "1.11"
 julia = "1.12"
+p7zip_jll = "17.5"

test/Project.toml

@@ -1,4 +1,5 @@
 [deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 HistoricalStdlibVersions = "6df8b67a-e8a0-4029-b4b7-ac196fe72102"
 LibGit2 = "76f85450-5226-5b5a-8eaa-529ad045b433"
@@ -15,4 +16,5 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 
 [compat]
+Aqua = "0.8.10"
 HistoricalStdlibVersions = "2"

test/aqua.jl

@@ -0,0 +1,2 @@
+using Aqua
+Aqua.test_all(Pkg)

test/runtests.jl

@@ -67,29 +67,37 @@ Logging.with_logger((islogging || Pkg.DEFAULT_IO[] == devnull) ? Logging.Console
 
     Utils.check_init_reg()
 
+    test_files = [
+        "new.jl",
+        "pkg.jl",
+        "repl.jl",
+        "api.jl",
+        "registry.jl",
+        "subdir.jl",
+        "extensions.jl",
+        "artifacts.jl",
+        "binaryplatforms.jl",
+        "platformengines.jl",
+        "sandbox.jl",
+        "resolve.jl",
+        "misc.jl",
+        "force_latest_compatible_version.jl",
+        "manifests.jl",
+        "project_manifest.jl",
+        "sources.jl",
+        "workspaces.jl",
+        "apps.jl",
+        ]
+
+    # Only test these if the test deps are available (they aren't typically via `Base.runtests`)
+    Aqua_pkgid = Base.PkgId(Base.UUID("4c88cf16-eb10-579e-8560-4a9242c79595"), "Aqua")
+    if Base.locate_package(Aqua_pkgid) !== nothing
+        push!(test_files, "aqua.jl")
+    end
+
     @testset "Pkg" begin
         try
-        @testset "$f" for f in [
-                "new.jl",
-                "pkg.jl",
-                "repl.jl",
-                "api.jl",
-                "registry.jl",
-                "subdir.jl",
-                "extensions.jl",
-                "artifacts.jl",
-                "binaryplatforms.jl",
-                "platformengines.jl",
-                "sandbox.jl",
-                "resolve.jl",
-                "misc.jl",
-                "force_latest_compatible_version.jl",
-                "manifests.jl",
-                "project_manifest.jl",
-                "sources.jl",
-                "workspaces.jl",
-                "apps.jl",
-                ]
+        @testset "$f" for f in test_files
                 @info "==== Testing `test/$f`"
                 flush(Pkg.DEFAULT_IO[])
                 include(f)