Make leading ] fix silent, and not during completions (#4328)

Author: IanButterworth

ext/REPLExt/completions.jl

@@ -249,7 +249,7 @@ end
 function _completions(input, final, offset, index; hint::Bool)
     statement, word_count, partial = nothing, nothing, nothing
     try
-        words = tokenize(input)[end]
+        words = tokenize(input; rm_leading_bracket = false)[end]
         word_count = length(words)
         statement, partial = core_parse(words)
         if final

src/REPLMode/REPLMode.jl

@@ -228,10 +228,9 @@ function lex(cmd::String)::Vector{QString}
     return filter(x -> !isempty(x.raw), qstrings)
 end
 
-function tokenize(cmd::AbstractString)
+function tokenize(cmd::AbstractString; rm_leading_bracket::Bool = true)
     cmd = replace(replace(cmd, "\r\n" => "; "), "\n" => "; ") # for multiline commands
-    if startswith(cmd, ']')
-        @warn "Removing leading `]`, which should only be used once to switch to pkg> mode"
+    if rm_leading_bracket && startswith(cmd, ']')
         cmd = string(lstrip(cmd, ']'))
     end
     qstrings = lex(cmd)

test/repl.jl

@@ -26,13 +26,13 @@ using ..Utils
 end
 
 @testset "accidental" begin
-    @test_logs (:warn, r"Removing leading.*") pkg"]?"
-    @test_logs (:warn, r"Removing leading.*") pkg"] ?"
-    @test_logs (:warn, r"Removing leading.*") pkg"]st"
-    @test_logs (:warn, r"Removing leading.*") pkg"] st"
-    @test_logs (:warn, r"Removing leading.*") pkg"]st -m"
-    @test_logs (:warn, r"Removing leading.*") pkg"] st -m"
-    @test_logs (:warn, r"Removing leading.*") pkg"]"  # noop
+    pkg"]?"
+    pkg"] ?"
+    pkg"]st"
+    pkg"] st"
+    pkg"]st -m"
+    pkg"] st -m"
+    pkg"]"  # noop
 end
 
 temp_pkg_dir() do project_path