Fix missed rename of Operations._compat. Add tests for interactive compat menu (#4344)

Author: IanButterworth

ext/REPLExt/compat.jl

@@ -1,7 +1,9 @@
 # TODO: Overload
-function _compat(ctx::Context; io = nothing)
+function _compat(ctx::Context; io = nothing, input_io = stdin)
     io = something(io, ctx.io)
-    can_fancyprint(io) || pkgerror("Pkg.compat cannot be run interactively in this terminal")
+    if input_io isa Base.TTY # testing uses IOBuffer
+        can_fancyprint(io) || pkgerror("Pkg.compat cannot be run interactively in this terminal")
+    end
     printpkgstyle(io, :Compat, pathrepr(ctx.env.project_file))
     longest_dep_len = max(5, length.(collect(keys(ctx.env.project.deps)))...)
     opt_strs = String[]
@@ -16,7 +18,7 @@ function _compat(ctx::Context; io = nothing)
     end
     menu = TerminalMenus.RadioMenu(opt_strs, pagesize = length(opt_strs))
     choice = try
-        TerminalMenus.request("  Select an entry to edit:", menu)
+        TerminalMenus.request(TerminalMenus.default_terminal(in = input_io, out = io), "  Select an entry to edit:", menu)
     catch err
         if err isa InterruptException # if ^C is entered
             println(io)
@@ -35,10 +37,12 @@ function _compat(ctx::Context; io = nothing)
         start_pos = length(prompt) + 2
         move_start = "\e[$(start_pos)G"
         clear_to_end = "\e[0J"
-        ccall(:jl_tty_set_mode, Int32, (Ptr{Cvoid}, Int32), stdin.handle, true)
+        if input_io isa Base.TTY
+            ccall(:jl_tty_set_mode, Int32, (Ptr{Cvoid}, Int32), input_io.handle, true)
+        end
         while true
             print(io, move_start, clear_to_end, buffer, "\e[$(start_pos + cursor)G")
-            inp = TerminalMenus._readkey(stdin)
+            inp = TerminalMenus._readkey(input_io)
             if inp == '\r' # Carriage return
                 println(io)
                 break
@@ -85,9 +89,11 @@ function _compat(ctx::Context; io = nothing)
         end
         buffer
     finally
-        ccall(:jl_tty_set_mode, Int32, (Ptr{Cvoid}, Int32), stdin.handle, false)
+        if input_io isa Base.TTY
+            ccall(:jl_tty_set_mode, Int32, (Ptr{Cvoid}, Int32), input_io.handle, false)
+        end
     end
     new_entry = strip(resp)
-    compat(ctx, dep, string(new_entry))
+    API._compat(ctx, dep, string(new_entry))
     return
 end

test/repl.jl

@@ -805,4 +805,36 @@ end
     @test Pkg.in_repl_mode() == false
 end
 
+@testset "compat REPL mode" begin
+    temp_pkg_dir() do project_path
+        with_pkg_env(project_path; change_dir = true) do
+
+            pkg"add Example JSON"
+
+            test_ctx = Pkg.Types.Context()
+            test_ctx.io = IOBuffer()
+
+            @test Pkg.Operations.get_compat_str(test_ctx.env.project, "Example") === nothing
+            @test Pkg.Operations.get_compat_str(test_ctx.env.project, "JSON") === nothing
+
+            input_io = Base.BufferStream()
+            # Send input to stdin before starting the _compat function
+            # This simulates the user typing in the REPL
+            write(input_io, "\e[B") # Down arrow once to select Example
+            write(input_io, "\r") # Enter to confirm selection
+            # now editing Example compat
+            write(input_io, "0.4") # Set compat to 0.4
+            write(input_io, "\r") # Enter to confirm input
+            close(input_io)
+
+            Pkg.API._compat(test_ctx; input_io)
+
+            str = String(take!(test_ctx.io))
+            @test occursin("Example = \"0.4\"", str)
+            @test occursin("checking for compliance with the new compat rules..", str)
+            @test occursin("Error empty intersection between", str) # Latest Example is at least 0.5.5
+        end
+    end
+end
+
 end # module