do not create a separate app environment for devved apps (#4465)

Author: KristofferC

src/Apps/Apps.jl

@@ -254,8 +254,10 @@ function develop(pkg::PackageSpec)
     manifest = ctx.env.manifest
     manifest.deps[pkg.uuid] = entry
 
-    _resolve(manifest, pkg.name)
-    precompile(pkg.name)
+    # For dev, we don't create an app environment - just point shims directly to the dev'd project
+    write_manifest(manifest, app_manifest_file())
+    generate_shims_for_apps(pkg.name, project.apps, sourcepath, joinpath(Sys.BINDIR, "julia"))
+
     @info "For package: $(pkg.name) installed apps: $(join(keys(project.apps), ","))"
     check_apps_in_path(project.apps)
 end

test/apps.jl

@@ -97,6 +97,12 @@ using Test
             # https://github.com/JuliaLang/Pkg.jl/issues/4258
             Pkg.Apps.add(path = path)
             Pkg.Apps.develop(path = path)
+
+            # Verify that dev does not create an app environment directory
+            app_env_dir = joinpath(first(DEPOT_PATH), "environments", "apps", "Rot13")
+            @test !isdir(app_env_dir)
+
+            # Verify that changes to the dev'd package are immediately reflected
             mv(joinpath(path, "src", "Rot13_edited.jl"), joinpath(path, "src", "Rot13.jl"); force = true)
             withenv("PATH" => string(joinpath(first(DEPOT_PATH), "bin"), sep, current_path)) do
                 @test read(`$exename test`, String) == "Updated!\n"