remove minimum iterations in test, just base on time

Author: IanButterworth

test/pkg.jl

@@ -363,7 +363,7 @@ temp_pkg_dir() do project_path
         @test any(x -> startswith(x, manifest), keys(usage))
     end
 
-    @time @testset "test atomicity of write_env_usage with $(Sys.CPU_THREADS) parallel processes" begin
+    @testset "test atomicity of write_env_usage with $(Sys.CPU_THREADS) parallel processes" begin
         tasks = Task[]
         iobs = IOBuffer[]
         Sys.CPU_THREADS == 1 && error("Cannot test for atomic usage log file interaction effectively with only Sys.CPU_THREADS=1")
@@ -372,19 +372,22 @@ temp_pkg_dir() do project_path
         flag_end_file = tempname() # use creating this file as a way to stop the processes early if an error happens
         for i in 1:Sys.CPU_THREADS
             iob = IOBuffer()
-            t = @async run(pipeline(`$(Base.julia_cmd()) --project="$(pkgdir(Pkg))"
+            t = @async run(pipeline(`$(Base.julia_cmd()[1]) --project="$(pkgdir(Pkg))"
                 -e "import Pkg;
                 Pkg.UPDATED_REGISTRY_THIS_SESSION[] = true;
                 Pkg.activate(temp = true);
                 Pkg.add(\"Random\", io = devnull);
-                i = 0
                 touch(tempname(raw\"$flag_start_dir\")) # file marker that first part has finished
                 while length(readdir(raw\"$flag_start_dir\")) < $(Sys.CPU_THREADS)
                     # sync all processes to start at the same time
                     sleep(0.1)
                 end
-                t = Timer(15)
-                while !isfile(raw\"$flag_end_file\") && (i <= 1000 || isopen(t))
+                @async begin
+                    sleep(15)
+                    touch(raw\"$flag_end_file\")
+                end
+                i = 0
+                while !isfile(raw\"$flag_end_file\")
                     global i += 1
                     try
                         Pkg.Types.EnvCache()
@@ -393,6 +396,7 @@ temp_pkg_dir() do project_path
                         println(stderr, \"Errored after $i iterations\")
                         rethrow()
                     end
+                    yield()
                 end"`,
                 stderr = iob, stdout = devnull))
             push!(tasks, t)