Skip to content

Commit 6091533

Browse files
authored
fix ambiguity in apps rm (#4144)
1 parent ecdf6aa commit 6091533

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

src/Apps/Apps.jl

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -243,21 +243,19 @@ end
243243

244244

245245
function require_not_empty(pkgs, f::Symbol)
246-
pkgs === nothing && return
247-
isempty(pkgs) && pkgerror("app $f requires at least one package")
246+
247+
if pkgs == nothing || isempty(pkgs)
248+
pkgerror("app $f requires at least one package")
249+
end
248250
end
249251

250252
rm(pkgs_or_apps::String) = rm([pkgs_or_apps])
251-
function rm(pkgs_or_apps::Union{Vector, Nothing})
252-
if pkgs_or_apps === nothing
253-
rm(nothing)
254-
else
255-
for pkg_or_app in pkgs_or_apps
256-
if pkg_or_app isa String
257-
pkg_or_app = PackageSpec(pkg_or_app)
258-
end
259-
rm(pkg_or_app)
253+
function rm(pkgs_or_apps::Vector)
254+
for pkg_or_app in pkgs_or_apps
255+
if pkg_or_app isa String
256+
pkg_or_app = PackageSpec(pkg_or_app)
260257
end
258+
rm(pkg_or_app)
261259
end
262260
end
263261

0 commit comments

Comments
 (0)