fix another URL scheme parsing in the repl mode (#4450)

(cherry picked from commit 946b4e1)

Author: KristofferC

src/REPLMode/argument_parsers.jl

@@ -34,9 +34,46 @@ end
 
 # Simple URL detection
 function looks_like_url(str::String)
-    return startswith(str, "http://") || startswith(str, "https://") ||
-           startswith(str, "git@") || startswith(str, "ssh://") ||
-           contains(str, ".git")
+    if startswith(str, "http://") || startswith(str, "https://") ||
+            startswith(str, "git@") || startswith(str, "ssh://") ||
+            contains(str, ".git")
+        return true
+    end
+
+    # Check for user@host:path pattern (SSH URL with user)
+    # This handles cases like: [email protected]:PackageName.jl
+    # The host part should not contain / or @ characters, and should come before the :
+    at_pos = findfirst('@', str)
+    if at_pos !== nothing
+        colon_pos = findnext(':', str, nextind(str, at_pos))
+        if colon_pos !== nothing
+            host_part = str[nextind(str, at_pos):(prevind(str, colon_pos))]
+            # Host should not contain / (which would suggest this is package@version:subdir syntax)
+            # and should look like a hostname or IP address (no spaces, etc.)
+            # Additionally, exclude things that look like version numbers (e.g., "1.0", "1.0.0")
+            # by checking if the host contains only digits and dots (which would be a version or IP)
+            # If it's all digits and dots, it must have at least 3 dots to be an IP (X.X.X.X)
+            if !contains(host_part, '/') && !contains(host_part, ' ') && !isempty(host_part)
+                # Check if this looks like a version number (e.g., "1.0", "1.0.0")
+                # vs an IP address (e.g., "10.20.30.40") or hostname (e.g., "server.com")
+                if all(c -> isdigit(c) || c == '.', host_part)
+                    # All digits and dots - could be version or IP
+                    # Count dots: version has 1-2 dots, IP has 3 dots
+                    dot_count = count(==('.'), host_part)
+                    if dot_count >= 3
+                        # Likely an IP address (X.X.X.X)
+                        return true
+                    end
+                    # else: likely a version number, not a URL
+                else
+                    # Contains letters or other chars - likely a hostname
+                    return true
+                end
+            end
+        end
+    end
+
+    return false
 end
 
 # Simple path detection
@@ -119,14 +156,13 @@ end
 function is_url_structure_colon(input::String, colon_pos::Int)
     after_colon = input[nextind(input, colon_pos):end]
 
-    # Check for git@host:path syntax
-    if startswith(input, "git@")
-        at_pos = findfirst('@', input)
-        if at_pos !== nothing
-            between_at_colon = input[nextind(input, at_pos):prevind(input, colon_pos)]
-            if !contains(between_at_colon, '/')
-                return true
-            end
+    # Check for user@host:path syntax (including git@host:path)
+    at_pos = findfirst('@', input)
+    if at_pos !== nothing && at_pos < colon_pos
+        between_at_colon = input[nextind(input, at_pos):prevind(input, colon_pos)]
+        # If there's no '/' between @ and :, this colon is part of the SSH URL structure
+        if !contains(between_at_colon, '/')
+            return true
         end
     end
 

src/utils.jl

@@ -24,7 +24,7 @@ function linewrap(str::String; io = stdout_f(), padding = 0, width = Base.displa
     return lines
 end
 
-const URL_regex = r"((file|git|ssh|http(s)?)|(git@[\w\-\.]+))(:(//)?)([\w\.@\:/\-~]+)(\.git)?(/)?"x
+const URL_regex = r"((file|git|ssh|http(s)?)|([\w\-\.]+@[\w\-\.]+))(:(//)?)([\w\.@\:/\-~]+)(\.git)?(/)?"x
 isurl(r::String) = occursin(URL_regex, r)
 
 stdlib_dir() = normpath(joinpath(Sys.BINDIR::String, "..", "share", "julia", "stdlib", "v$(VERSION.major).$(VERSION.minor)"))

test/new.jl

@@ -1117,6 +1117,21 @@ end
             @test args[1].rev == "branch-name"
         end
 
+        # Test SSH URLs with IP addresses (issue #1822)
+        @testset "SSH URLs with IP addresses" begin
+            # Test that user@host:path URLs with IP addresses are parsed correctly as complete URLs
+            api, args, opts = first(Pkg.pkg"add [email protected]:PackageName.jl")
+            @test api == Pkg.add
+            @test length(args) == 1
+            @test args[1].url == "[email protected]:PackageName.jl"
+            @test args[1].subdir === nothing
+
+            api, args, opts = first(Pkg.pkg"add [email protected]:path/to/repo.jl")
+            @test api == Pkg.add
+            @test length(args) == 1
+            @test args[1].url == "[email protected]:path/to/repo.jl"
+            @test args[1].subdir === nothing
+        end
 
         # Test Git URLs with subdir specifiers
         @testset "Git URLs with subdir specifiers" begin