Precompile: add strict kwarg to control whether indirect deps throw (#2362)

* add fail_indirect_deps kwarg

* update pkgerror to reflect fail_indirect_deps

* change kwarg to throw_indirect_deps

* fix spacing

* better docstring wording

* switch to `strict`

(cherry picked from commit 8fbdbd9)

Author: IanButterworth

src/API.jl

@@ -910,7 +910,7 @@ function make_pkgspec(man, uuid)
 end
 
 precompile(; kwargs...) = precompile(Context(); kwargs...)
-function precompile(ctx::Context; internal_call::Bool=false, kwargs...)
+function precompile(ctx::Context; internal_call::Bool=false, strict::Bool=false, kwargs...)
     Context!(ctx; kwargs...)
     instantiate(ctx; allow_autoprecomp=false, kwargs...)
     time_start = time_ns()
@@ -1144,7 +1144,7 @@ function precompile(ctx::Context; internal_call::Bool=false, kwargs...)
                         end
                     catch err
                         if err isa ErrorException
-                            failed_deps[pkg] = is_direct_dep ? String(take!(iob)) : ""
+                            failed_deps[pkg] = (strict || is_direct_dep) ? String(take!(iob)) : ""
                             !fancyprint && lock(print_lock) do
                                 println(io, string(color_string("  ✗ ", Base.error_color()), name))
                             end
@@ -1213,15 +1213,16 @@ function precompile(ctx::Context; internal_call::Bool=false, kwargs...)
             err_str = ""
             n_direct_errs = 0
             for (dep, err) in failed_deps
-                if dep in direct_deps
+                if strict || (dep in direct_deps)
                     err_str *= "\n" * "$dep" * "\n\n" * err * (n_direct_errs > 0 ? "\n" : "")
                     n_direct_errs += 1
                 end
             end
             if err_str != ""
                 println(io, "")
                 plural = n_direct_errs == 1 ? "y" : "ies"
-                pkgerror("The following $( n_direct_errs) direct dependenc$(plural) failed to precompile:\n$(err_str[1:end-1])")
+                direct = strict ? "" : "direct "
+                pkgerror("The following $n_direct_errs $(direct)dependenc$(plural) failed to precompile:\n$(err_str[1:end-1])")
             end
         end
     end

src/Pkg.jl

@@ -127,12 +127,13 @@ See also [`PackageSpec`](@ref).
 const add = API.add
 
 """
-    Pkg.precompile()
+    Pkg.precompile(; strict::Bool=false)
 
 Precompile all the dependencies of the project in parallel.
 !!! note
     Errors will only throw when precompiling the top-level dependencies, given that
     not all manifest dependencies may be loaded by the top-level dependencies on the given system.
+    This can be overridden to make errors in all dependencies throw by setting the kwarg `strict` to `true`
 
 !!! note
     This method is called automatically after any Pkg action that changes the manifest.