Error if the stdlib version requested mismatches current version (#4335)

Author: IanButterworth

src/Operations.jl

@@ -524,6 +524,37 @@ function get_compat_workspace(env, name)
     return compat
 end
 
+function check_stdlib_version_compat!(pkg::PackageSpec, julia_version)
+    julia_version === nothing && return
+    pkg.version === nothing && return
+    @assert pkg.uuid !== nothing
+
+    if !(is_stdlib(pkg.uuid, julia_version) && !(pkg.uuid in Types.UPGRADABLE_STDLIBS_UUIDS))
+        return
+    end
+
+    current_stdlib_version = Types.stdlib_version(pkg.uuid, julia_version)
+    current_stdlib_version === nothing && return
+
+    # Check if the requested version conflicts with current stdlib version
+    version_conflicts = if pkg.version isa VersionNumber
+        pkg.version != current_stdlib_version
+    elseif pkg.version isa VersionSpec
+        !(current_stdlib_version in pkg.version)
+    else
+        error("Unexpected version spec type for stdlib `$(pkg.name)`: $(typeof(pkg.version))")
+    end
+
+    return if version_conflicts
+        throw(
+            Resolve.ResolverError(
+                """Cannot add stdlib `$(pkg.name)` with version specification `$(pkg.version)`.
+                The current Julia version v$(julia_version) uses `$(pkg.name)` v$(current_stdlib_version)."""
+            )
+        )
+    end
+end
+
 # Resolve a set of versions given package version specs
 # looks at uuid, version, repo/path,
 # sets version to a VersionNumber
@@ -579,6 +610,9 @@ function resolve_versions!(
                 )
             )
         end
+
+        check_stdlib_version_compat!(pkg, julia_version)
+
         # Work around not clobbering 0.x.y+ for checked out old type of packages
         if !(pkg.version isa VersionNumber)
             pkg.version = v

test/api.jl

@@ -448,4 +448,67 @@ end
     end
 end
 
+@testset "Stdlib version validation" begin
+    isolate() do
+        Pkg.activate(temp = true)
+
+        # Test that adding a stdlib with wrong version fails
+        pkg_uuid = Base.UUID("44cfe95a-1eb2-52ea-b672-e2afdf69b78f") # Pkg stdlib UUID
+        current_pkg_version = Pkg.Types.stdlib_version(pkg_uuid, VERSION)
+
+        # Create a fake wrong version that's different from current
+        wrong_version = VersionNumber(current_pkg_version.major, current_pkg_version.minor + 1, 0)
+
+        # Test that adding Pkg with wrong version throws an error
+        @test_throws r"Cannot add stdlib `Pkg` with version " Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = wrong_version))
+
+        # Test that adding Pkg with correct version works (should be a no-op)
+        @test_nowarn Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = current_pkg_version))
+
+        Pkg.activate(temp = true)
+        # Test that upgradable stdlibs (downgradable too) are not affected by version validation
+        # DelimitedFiles is an upgradable stdlib
+        delim_files_uuid = Base.UUID("8bb1440f-4735-579b-a4ab-409b98df4dab")
+        # Should be able to add DelimitedFiles with any version without error
+        old_version = v"1.9.0" # julia 1.13.0 is on v1.9.1
+        @test Pkg.Types.stdlib_version(delim_files_uuid, VERSION) != old_version
+        # We expect this might fail for resolver reasons, but NOT for stdlib version validation
+        Pkg.add(Pkg.PackageSpec(name = "DelimitedFiles", uuid = delim_files_uuid, version = old_version))
+        @test Pkg.dependencies()[delim_files_uuid].version == old_version
+
+        Pkg.activate(temp = true)
+        # Test VersionSpec validation (like REPL "Package@version" syntax)
+        # Test that adding Pkg with wrong version via VersionSpec throws an error
+        wrong_version_spec = Pkg.Versions.VersionSpec(wrong_version)
+        @test_throws r"Cannot add stdlib `Pkg` with version " Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = wrong_version_spec))
+
+        Pkg.activate(temp = true)
+        # Test that adding Pkg with correct version via VersionSpec works
+        correct_version_spec = Pkg.Versions.VersionSpec(current_pkg_version)
+        @test_nowarn Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = correct_version_spec))
+
+        Pkg.activate(temp = true)
+        # Test that VersionSpec with ranges that include current version work
+        # This should work as the current version is within the range
+        version_range_spec = Pkg.Versions.VersionSpec("*")  # Allow any version
+        @test_nowarn Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = version_range_spec))
+
+        Pkg.activate(temp = true)
+        # Test String version validation (like REPL "Package@version" syntax)
+        # Test that adding Pkg with wrong version via String throws an error
+        wrong_version_string = string(wrong_version)
+        @test_throws r"Cannot add stdlib `Pkg` with version " Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = wrong_version_string))
+
+        Pkg.activate(temp = true)
+        # Test that adding Pkg with correct version via String works
+        correct_version_string = string(current_pkg_version)
+        @test_nowarn Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = correct_version_string))
+
+        Pkg.activate(temp = true)
+        # Test stdlib not in manifest scenario (fresh environment)
+        # This tests the first update_package_add method with ::Nothing entry
+        @test_throws r"Cannot add stdlib `Pkg` with version " Pkg.add(Pkg.PackageSpec(name = "Pkg", uuid = pkg_uuid, version = wrong_version))
+    end
+end
+
 end # module APITests