fix dev taking when the app is already installed (#4259)

Co-authored-by: KristofferC <[email protected]>
(cherry picked from commit a94a6bc)

Author: 2 people

src/Apps/Apps.jl

@@ -78,7 +78,6 @@ function _resolve(manifest::Manifest, pkgname=nothing)
         end
 
         projectfile = joinpath(app_env_folder(), pkg.name, "Project.toml")
-        sourcepath = source_path(app_manifest_file(), pkg)
 
         # TODO: Add support for existing manifest
         # Create a manifest with the manifest entry
@@ -87,12 +86,8 @@ function _resolve(manifest::Manifest, pkgname=nothing)
             if isempty(ctx.env.project.deps)
                 ctx.env.project.deps[pkg.name] = uuid
             end
-            if isempty(ctx.env.manifest)
-                ctx.env.manifest.deps[uuid] = pkg
-                Pkg.resolve(ctx)
-            else
-                Pkg.instantiate(ctx)
-            end
+            ctx.env.manifest.deps[uuid] = pkg
+            Pkg.resolve(ctx)
         end
 
         # TODO: Julia path

test/apps.jl

@@ -33,6 +33,14 @@ isolate(loaded_depot=true) do
             Pkg.Apps.rm("Rot13")
             @test Sys.which(exename) == nothing
         end
+
+        # https://github.com/JuliaLang/Pkg.jl/issues/4258
+        Pkg.Apps.add(path=path)
+        Pkg.Apps.develop(path=path)
+        mv(joinpath(path, "src", "Rot13_edited.jl"), joinpath(path, "src", "Rot13.jl"); force=true)
+        withenv("PATH" => string(joinpath(first(DEPOT_PATH), "bin"), sep, current_path)) do
+            @test read(`$exename test`, String) == "Updated!\n"
+        end
     end
 end
 

test/test_packages/Rot13.jl/src/Rot13_edited.jl

@@ -0,0 +1,7 @@
+module Rot13
+
+function (@main)(ARGS)
+    println("Updated!")
+end
+
+end # module Rot13